This repository was archived by the owner on Dec 4, 2017. It is now read-only.
fix(api-builder): escape double-quotes in JSON output #2324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
petebacondarwin
added a commit
to angular/dgeni-packages
that referenced
this pull request
Sep 13, 2016
Related to angular/angular.io#2321 Related to angular/angular.io#2324 BREAKING CHANGE: Previously, if there were multiple declarations for an exported symbol, then the docs for those declarations were simply joined together with newlines. Now only the first declaration (or the valueDeclaration if there is one) is used in an export doc. If you needed the content for the other declarations then you can still access them via a call like `getContent(doc.additionalDeclarations[i])`.
| @@ -7,7 +7,7 @@ | |||
| "docType": "{$ item.docType $}", | |||
| "stability": "{$ item.stability $}", | |||
There was a problem hiding this comment.
both stability and security fields can contain free-form text. we should escape those too.
|
@naomiblack you missed the comment above. this solution is incomplete and the site will still break eventually. |
|
oh.. I see. the json actually doesn't contain the user provided text, that is only used in non-json contexts. this change is fine then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2321
@naomiblack and @IgorMinar