Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Conversation

tiangolo
Copy link
Contributor

The current link in the Routing tutorial leads to a 404 error.

This update fixes that to point to the correct GitHub "raw" file link. Nevertheless, in the "Quickstart" the link takes to the normal GitHub page, not the "raw" file.


Also, it isn't very clear that for relative "asset" loading (html and css files) it's needed to set the moduleId variable in every @Component declaration to module.id. Otherwise the loading fails. (It took me some time to discover that).

As in:

@Component({
  moduleId: module.id,
  selector: 'my-dashboard',
  templateUrl: 'dashboard.component.html',
  styleUrls: ['dashboard.component.css']
})
export class DashboardComponent implements OnInit {

...

Should I try to add that to the guide to make it more clear in another PR?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@tiangolo
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@Foxandxss Foxandxss merged commit 4f81a7e into angular:master Oct 13, 2016
@Foxandxss
Copy link
Member

Thanks. The moduleId is being fixed in a different PR.

@tiangolo
Copy link
Contributor Author

Thanks! That was a fast merge 🎉 !

And thanks for the clarification about the moduleId.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants