This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore: don't shred _boilerplate files nor dart build files #2747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@filipesilva - finally, I think this will fix my problems with the shredder processing Dart build files! W/o this change, some folders would have 1000 files processed in parallel. |
filipesilva
reviewed
Nov 4, 2016
| @@ -808,7 +808,7 @@ gulp.task('_harp-compile', function() { | |||
|
|
|||
| gulp.task('_shred-devguide-examples', ['_shred-clean-devguide', '_copy-example-boilerplate'], function() { | |||
| // Split big shredding task into partials 2016-06-14 | |||
| var examplePaths = globby.sync(EXAMPLES_PATH+'/*/', {ignore: ['/node_modules']}); | |||
| var examplePaths = globby.sync(EXAMPLES_PATH+'/*/', {ignore: ['**/_boilerplate']}); | |||
There was a problem hiding this comment.
Why is /node_modules not ignores anymore?
There was a problem hiding this comment.
Because it isn't needed: there is no node_modules as a direct subfolder of _examples.
There was a problem hiding this comment.
We discussed offline and turns out the folder still exists.
chalin
force-pushed
the
chalin-dont-shred-build-or-tmp-files-1103
branch
from
a06360e to
1eb6b4f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.