This repository was archived by the owner on Dec 4, 2017. It is now read-only.
fix(toh-6): add missing tsconfig file #3289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
suggested changes
Feb 21, 2017
| "lib": [ "es2015", "dom" ], | ||
| "noImplicitAny": true, | ||
| "suppressImplicitAnyIndexErrors": true, | ||
| "typeRoots": [ |
There was a problem hiding this comment.
Can you use https://github.com/angular/angular.io/blob/master/public/docs/_examples/quickstart/ts/src/tsconfig.1.json here instead of the auto-generated one? It's incorrect insofar as it contains some invalid excludes and typeRoots for user projects.
petebacondarwin
force-pushed
the
missing-tsconfig-file
branch
from
838b44b to
496528c
Compare
filipesilva
approved these changes
Feb 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.