This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs: followup amends for 4.0 release #3431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardbell
approved these changes
Mar 24, 2017
| @@ -353,7 +354,7 @@ figure | |||
| +makeExample('animations/ts/src/app/hero-list-multistep.component.ts', 'template', 'hero-list-multistep.component.ts (excerpt)')(format=".") | |||
|
|
|||
| :marked | |||
| The callbacks receive an `AnimationTransitionEvent` which contains useful properties such as `fromState`, | |||
| The callbacks receive an `AnimationEvent` which contains useful properties such as `fromState`, | |||
There was a problem hiding this comment.
Should be that contains but that is a grammar nit.
| @@ -890,7 +890,7 @@ block dart-map-alternative | |||
| An `Injector` is itself an injectable service. | |||
|
|
|||
| In this example, Angular injects the component's own `Injector` into the component's constructor. | |||
| The component then asks the injected injector for the services it wants. | |||
| The component then asks the injected injector for the services it wants on `ngOnInit`. | |||
There was a problem hiding this comment.
OK but better would be "in ngOnInit(). Use "in" instead of "on"
Kapunahele has started highlighting method names by putting parens after them. I think it's a good idea. We'll have a lot of prose to fix if we follow her lead. We can start any time :)
filipesilva
force-pushed
the
prose-changes-for-4.0
branch
from
c42b00f to
5ed6a5a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @wardbell