Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to get value of the property 'nodeName': object is null or undefined #10078

Closed
uriklar opened this Issue Nov 16, 2014 · 10 comments

Comments

@uriklar
Copy link

uriklar commented Nov 16, 2014

I'm including svgs using and
Example:

<symbol viewBox="0 0 16 16" id="svg-icon-collapse-arrow"><title>collapse-arrow</title> <path style="fill-rule:evenodd;clip-rule:evenodd;" d="M2.859,5.826l0.818-0.822l4.319,4.348l4.325-4.348l0.818,0.823l-5.145,5.169L2.859,5.826z"/> </symbol>

<svg xmlns="http://www.w3.org/2000/svg" ng-click="someMethod()">
    <use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#svg-icon-collapse-arrow" />
</svg>

And am getting an error (only in IE9):

Unable to get value of the property 'nodeName': object is null or undefined

This error only occurs in v1.3.2. It doesn't even happen in the 1.3 beta versions

@pkozlowski-opensource

This comment has been minimized.

Copy link
Member

pkozlowski-opensource commented Nov 16, 2014

@uriklar if you could put your code in http://plnkr.co/ or similar and provide a live reproduce scenario that would speed up things.

@uriklar

This comment has been minimized.

Copy link
Author

uriklar commented Nov 17, 2014

I added the code in http://plnkr.co/edit/#/IgIC1Hz87SElVAqiNCPM?p=catalogue but as for nowit won't reproduce. But in my app, as soon as I replaced the use with simply injecting the symbol content in the svg tag the problem was solved. Not sure what else in my app is causing the error

@pkozlowski-opensource

This comment has been minimized.

Copy link
Member

pkozlowski-opensource commented Nov 17, 2014

@uriklar yeh, we will need to isolate this one in order to move forward...

@uriklar

This comment has been minimized.

Copy link
Author

uriklar commented Nov 20, 2014

@pkozlowski-opensource Ok, I got the plunkr isolating the issue. Here it is: http://plnkr.co/edit/ej3cqYnqAdCnxiNYvFhz

The issue happens in IE9. Try clicking the svg icons a few times and you'll start getting the error:
Unable to get value of the property 'nodeName': object is null or undefined

@pkozlowski-opensource

This comment has been minimized.

Copy link
Member

pkozlowski-opensource commented Nov 20, 2014

@uriklar thnx, I can reproduce it systematically with the latest SNAPSHOT clicking on the second icon on IE9: http://plnkr.co/edit/yIXDfMdUvmb9XRU9xPTC?p=preview

@uriklar

This comment has been minimized.

Copy link
Author

uriklar commented Nov 20, 2014

Great. let me know if there's something I can do to help

@metamatt

This comment has been minimized.

Copy link
Contributor

metamatt commented Nov 20, 2014

This also happens in Safari (8 for sure, and probably earlier) and older versions of Chrome (before 37).

@pkozlowski-opensource

This comment has been minimized.

Copy link
Member

pkozlowski-opensource commented Nov 22, 2014

Yes, true, it happens on the Safari 7 as well.

@pkozlowski-opensource

This comment has been minimized.

Copy link
Member

pkozlowski-opensource commented Nov 22, 2014

So, this is essentially the same as #8118 and since it affects multiple browsers we should fix it. Working on a patch.

@pkozlowski-opensource

This comment has been minimized.

Copy link
Member

pkozlowski-opensource commented Nov 22, 2014

Here is a minimal reproduce scenario that breaks in Safari7: http://plnkr.co/edit/7C4fpO2Z94HFXE8VUB7a?p=preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.