Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ngAnimate - ngSwitch not working #11769

Closed
karol-f opened this Issue Apr 30, 2015 · 1 comment

Comments

Projects
None yet
3 participants
@karol-f
Copy link

karol-f commented Apr 30, 2015

Overview of issue

Animation of ngSwitch stopped working in 1.4

Version

1.4 (e.g. RC0, RC1)

Reproduce

Not working (example in documentation of current 1.4 version)

https://docs.angularjs.org/api/ng/directive/ngSwitch#example

Working (example in documentation of current 1.3 version)

https://code.angularjs.org/1.3.15/docs/api/ng/directive/ngSwitch#example

Expected

Expecting ngSwitch animation working when ngAnimate module is loaded.

@petebacondarwin petebacondarwin added this to the 1.4.0-rc.2 milestone May 1, 2015

matsko added a commit to matsko/angular.js that referenced this issue May 5, 2015

fix(ngAnimate): ensure that the temporary CSS classes are applied bef…
…ore detection

Prior to 1.4 the `ng-animate` CSS class was applied before the CSS
getComputedStyle detection was issued. This was lost in the 1.4
refactor, however, this patch restores the functionality.

Closes angular#11769
@matsko

This comment has been minimized.

Copy link
Member

matsko commented May 5, 2015

Thank you for finding this issue. This is pretty important bug. There is a PR ready which fixes it #11804.

@matsko matsko closed this in f7e9ff1 May 7, 2015

netman92 added a commit to netman92/angular.js that referenced this issue Aug 8, 2015

fix(ngAnimate): ensure that the temporary CSS classes are applied bef…
…ore detection

Prior to 1.4 the `ng-animate` CSS class was applied before the CSS
getComputedStyle detection was issued. This was lost in the 1.4
refactor, however, this patch restores the functionality.

Closes angular#11769
Closes angular#11804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.