$cookieStore not working in IE or Safari

[patrickjamesbarry]

I just finished creating my first angular app, and submitting this bug out of memory. Using AngularJS 1.0.1. My app checks for presence of params stored in session cookies, via $cookieStore. If the params were not found, then user was redirected using $location service to the login page. This worked great in Chrome and firefox, but is broken in IE 8 and I believe Safari (latest). I had to abandon the $cookieStore and use jStorage instead.

[dansmithy]

This is also raised as issue 1090 (#1090). Can this get labelled as a bug?

[JensRantil]

I am too experiencing this issue on Safari or Internet Explorer 9 with angularJS and angularjs-cookie 1.0.1. Setting and retrieving value works fully in Chromium 18.0.1025.151 and Firefox 14.0.1. Not sure whether it's setting or retrieving value that fails. Is it possible to list cookies set in Safari?

My specific usecase is:

1. Load controller for a page that has a checkbox bound to an ng-model. In controller;
   1. If $cookies.mycookie is set to 'true' change ng-model value to true, else false.
   2. Watch the ng-model using a callback. Set a cookie using the $cookies factory on change. If checkbox is checked, store 'true', else 'false'.
2. Check the checkbox (that default to unchecked).
3. Leave the page and go back to it. Expected result is checkbox to be checked. It is not in Safari and IE 9.

[JensRantil]

FYI; I am currently using jStorage (as mentioned in #1090) until a workaround for this has been established.

[levyuk]

Any further information on this? I think the issue is probably with the cookieStore.put method.

[pchronz]

+1 major issue if you rely on angular from my point of view.

[SET001]

+1, still an issue!

[vasa-chi]

+1 major issue!

[aziz]

I also couldn't get the $cookieStore to work for me. went back to jQuery plugins for now! :(

[nilnullzip]

Found it. The problem occurs in this line in browser.cookie (in angular.js) because cookiePath is undefined:

    cookieLength = (rawDocument.cookie = escape(name) + '=' + escape(value) + ';path=' + cookiePath).length + 1;

The resulting string ends in "path=undefined". This string is passed to the native document.cookie setter function. It seems that Safari and Chrome have different behavior here and Chrome is more forgiving. Chrome treats the string as if it ended as "path=" and assigns the cookie accordingly, while Safari silently ignores the cookie assignment and leaves the cookie unchanged.

The fix/workaround can be applied a few lines earlier to where cookiePath is assigned:

var cookiePath = self.baseHref();

Add the line below so that cookiePath will become "" instead of "undefined"

var cookiePath = self.baseHref();
if (!cookiePath) {cookiePath = ""}

NOTE: the reason cookiePath can be undefined is because the code derives it from the tag in the document. The undefined result occurs when no tag is specified. The thing I don't understand is whether it is desirable to always set path from base. It seems perhaps a non-obvious consequence of setting .

[frapontillo]

The workaround works and is needed, why don't you make a pull request?

[jkeys089]

+1

[jfleong]

+1

[bwu]

+1

[lucsky]

+1, currently having to use the jquery.cookie plugin because of this.

[DavidFrahm]

+1, and fyi this is broken in Safari in iOS also

[gflarity]

+1

Thanks Fredrik, I just verified this fix worked for me. Please merge this, it's a pretty severe bug!

[IgorMinar]

fixed by 7cb8f8f