[angular 1.5.4] $onChanges hook will not be called if an exception is thrown

[bogdanalexe90]

Note: for support questions, please use one of these channels: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question. This repository's issues are reserved for feature requests and bug reports.

Do you want to request a feature or report a bug?
Report a bug

What is the current behavior?
I have 2 components, both using $onChanges. If one of them is throwing an exception the $onChanges hook is not called anymore for the next changes.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (template: http://plnkr.co/edit/tpl:yBpEi4).

http://plnkr.co/edit/wLXecrKvw2u4RFV6wmmp?p=preview

What is the expected behavior?

The $onChanges hook should be called every time there is a change.

What is the motivation / use case for changing the behavior?

Which versions of Angular, and which browser / OS are affected by this issue? Did this work in previous versions of Angular? Please also test with the latest stable and snapshot (https://code.angularjs.org/snapshot/) versions.

angular 1.5.4 and angular 1.5.3

Other information (e.g. stacktraces, related issues, suggestions how to fix)

[Narretz]

@petebacondarwin can you take a look at this?

I can say that the problem doesn't come from the fact that there are two components. One is enough. And somehow, throwing in an onChange fn throws off (heh) the change queue flushing.

[petebacondarwin]

OK. This is a valid bug. The question is what do want to do when any of the hooks throw errors?

[petebacondarwin]

The plan is to have the same behaviour to watch handlers. We should catch the error and recover the rest of the application.