Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

$controller called in finally statement doesn't log errors #15241

@aartek

Description

@aartek

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
errors comes from controller created with $controller are not logged into console when $controller is called in promise's finally statement.

Steps to reproduce
Call $controller with not existing dependency, or something wrong in code (i.e null pointer), in promise's finally statement. Errors will not be logged in console.

Example (open developer console):
http://plnkr.co/edit/ud0yCCC8IRM3heW7a2Ln?p=preview
In this example two errors should be logged, but there is only one, which comes from the first promise with then statement. $controller called in finally does not show any errors.

What is the expected behavior?
$controller called in finally should log errors.

Motivation
I use $controller to create controllers dynamically, with given name, and I inject there some dependencies (by locals argument). It's really hard to debug these controllers, when errors are not visible in console.

Which versions of Angular, and which browser / OS are affected by this issue? Did this work in previous versions of Angular? Please also test with the latest stable and snapshot (https://code.angularjs.org/snapshot/) versions.
I think it's long a time issue but for sure it doesn't work on 1.5.x in Chrome.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions