ng-if removes child element before destroying scope

[andrewdavey]

Currently ng-if removes the child element before destroying the child scope.

https://github.com/angular/angular.js/blob/master/src/ng/directive/ngIf.js#L90

I'm creating a directive that wraps Uploadify file upload control. The directive destroys the Uploadify widget when the scope gets the $destroy event.

When placed inside something with ng-if applied, destroying the Uploadify widget causes exceptions in IE8. Uploadify gets the SWF element by ID, but ng-if has already detached the elements from the DOM, so getElementById returns null.

Is it OK to simply reorder the code in ng-if to destroy the scope first? Or does that break other things?

[petebacondarwin]

Hmm, I wonder if the leave animations need to rely upon the $scope being there? ngRepeat works in the same way.

[petebacondarwin]

Related to #3089

[petebacondarwin]

You can get what you need using the special jqLite/jQuery $destroy event, which is called just before any DOM element is removed.

See https://github.com/angular/angular.js/blob/master/src/jqLite.js#L113.

In your directive that brings in the Uploadify widget you have access to the element so you can do something like:

element.on('$destroy', function() {
  // remove uploadify
});

[andrewdavey]

Ah, of course. Thanks :)