ng-bind on checkbox with ng-click happens in wrong order

[supercobra]

In case of a checkbox with ng-click and ng-model like this:

<input type='checkbox' ng-click='onCompleteTodo(todo)' ng-model="todo.done">

If a user clicks on this checkbox, onCompleteTodo(todo) contains the valuebefore` the click happened.

Fiddle:

• http://jsfiddle.net/supercobra/ekD3r/

The argument is that, since the click occurred before the call to onCompleteTodo (or whatever method) the method should be presented with the current value, in this case a checkbox that has been clicked.

[caitp]

This is the order in which directives are collected and prioritized: https://github.com/angular/angular.js/blob/master/src/ng/compile.js#L1666

I suppose that, since ng-click and ng-model both have a default priority of 0, ng-click is prioritized ahead of ng-model because of its name.

This might seem silly (and perhaps it is), but it does at least make things somewhat deterministic. It might make more sense to use the index of the directive instead, however

[petebacondarwin]

Have you tried ng-change instead?
On 4 Nov 2013 08:23, "Caitlin Potter" notifications@github.com wrote:

This is the order in which directives are collected and prioritized:
https://github.com/angular/angular.js/blob/master/src/ng/compile.js#L1666

I suppose that, since ng-click and ng-model both have a default priority
of 0, ng-click is prioritized ahead of ng-model because of its name.

This might seem silly (and perhaps it is), but it does at least make
things somewhat deterministic. It might make more sense to use the index of
the directive instead, however

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4765#issuecomment-27669176
.

[supercobra]

FYI this was working before 1.2-RC3. RC3 broke it.

[caitp]

Perhaps 31f190d ?

BREAKING CHANGE: the order of postLink fn is now mirror opposite of
the order in which corresponding preLinking and compile functions
execute.

Very few directives in practice rely on order of postLinking function
(unlike on the order of compile functions), so in the rare case
of this change affecting an existing directive, it might be necessary
to convert it to a preLinking function or give it negative priority
(look at the diff of this commit to see how an internal attribute
interpolation directive was adjusted)

[supercobra]

Good point about 31f190d

However, I think there is a philosophical issue: Angular should 'show the truth'. I.e., If a checkbox is clicked, the clicked call back function (ng-click) should see a model that has a 'checkbox checked' value based on the last click. The fiddle http://jsfiddle.net/supercobra/ekD3r/ shows a logical contradiction.

[caitp]

I'm not sure it really makes sense to even perform a string comparison for directive names when determining ordering, so removing that would be a super simple "fix"... I don't really know what use care there is for that.

But that said, I mean, as a work around you could define a copy of the ng-click directive with a "greater" name, so that it would be prioritized in the order you want.

I totally agree that that is a silly thing, but looking at the code, it should work.

[fijolekProjects]

Here's working workaround: http://jsfiddle.net/ekD3r/4/
It's not pretty, but it works ;)
Thanks @caitp !

[kereg]

With ng-change its works as you would expect

[pieterbeens]

Had the same problem, changing it to ng-change did the trick!

[IgorMinar]

@caitp we can't use index of the directive because then loading scripts in different order would result in different behavior == non-deterministic.

I know that the current ordering is not ideal, but when I made it this way, the number one goal was to make it deterministic.

without diving into the code I'm can't tell for sure if it's the directive precedence that causes this issue. I'm suspecting that we see this bug because the click event happens first and only as a result of the click event the model changes.

I however agree that this is not intuitive and it is desirable to delay the evaluation of the ngClick expression until the model is up to date.

I do wonder how tricky it is to get this behavior.

[michaelholst]

Wow, we just migrated from 1.0 to 1.2 and this caught us completely off guard.

It's counter-intuitive to say the least, a checkbox in not a normal button and the click itself changes its state.