Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing $browser.defer(), add $defer mock, clear $defer #532

Closed
vojtajina opened this issue Aug 23, 2011 · 1 comment
Closed

removing $browser.defer(), add $defer mock, clear $defer #532

vojtajina opened this issue Aug 23, 2011 · 1 comment
Labels

Comments

@vojtajina
Copy link
Contributor

@vojtajina vojtajina commented Aug 23, 2011

  • get rid off $browser.defer()
  • use $defer mock during testing
  • $defer should have API for clearing
  • scope.$apply() inside $defer callback should be optional, so that you can do low level stuff without triggering $apply
  • should emit 'asyncStart', 'asyncEnd' events for scenario runner

Related issue: #469

IgorMinar added a commit to IgorMinar/angular.js that referenced this issue May 23, 2012
$timeout has a better name ($defer got often confused with something related to $q) and
is actually promise based with cancelation support.

With this commit the $defer service is deprecated and will be removed before 1.0.

Closes angular#704, angular#532
@pkozlowski-opensource
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented Dec 15, 2012

This was fixed in 4511d39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.