ngAnimate crash regression between 1.2.13 and 1.2.14

[mgcrea]

I got crashing animations since 1.2.14, usually when the $animate.enter is called while the $animate.leave is running. For instance if you hover very fast between two tooltips.

Worked flawlessly with angular v1.2.13:

• http://plnkr.co/edit/x5DFnQXo7xYKLkY7MoPx?p=preview

Crashes with angular v1.2.14:

• http://plnkr.co/edit/D0cKtVrJSzQWUpdEgSuH?p=preview

Uncaught TypeError: Cannot read property 'length' of null
angular-animate.js:290

Which translate to this line:
https://github.com/angular/angular.js/blob/v1.2.14/src/ngAnimate/animate.js#L284

The only change regarding ngAnimate between v1.2.13 and v1.2.14 seems to be the replace of done && $timeout(done, 0, false); by async(done).

@matsko Do you have any idea where this regression might come from?

---

I've tested ngAnimate#1.2.13 with angular#1.2.15-build.2389+sha.c5f2f58 and it still works, so it looks like this is a bug confined into ngAnimate.

[Narretz]

There was also a huge change regarding setClass / addClass / removeClass:

18c41af

[matsko]

I'm checking it out. I don't think that the callback issue could be to blame, but possibly the way that cancellations are done.

@Narretz yes there were two big commits (one for 1.2.13 and another for 1.2.14) that made the setClass animations possible (1.2.14 made it so that if setClass is not present then it breaks down into addClass + removeClass). This shouldn't have effected it, however, the commit that you posted may be causing the issue due to the way that the runner code was refactored.

[mgcrea]

@Narretz That's strange, the compare view did not show theses changes, the diff might be a bit big for it to work correctly.

Will be happy to help if there is anything I can do.

[matsko]

Still looking into this. I can reproduce the bug, but it's hard to track down.