Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

feat(http): Please make buildUrl public #7429

Closed
donaldpipowitch opened this issue May 12, 2014 · 11 comments
Closed

feat(http): Please make buildUrl public #7429

donaldpipowitch opened this issue May 12, 2014 · 11 comments

Comments

@donaldpipowitch
Copy link

Feature Request:
It would be great if buildUrl would be public. It is a function which was copied nearly identical into Restangular and I had to do the same for a private module.

@tbosch tbosch added this to the Backlog milestone May 21, 2014
@btford btford removed the gh: issue label Aug 20, 2014
@donaldpipowitch
Copy link
Author

Any progress on this? We need to do this again for some mocking API service.

@pkozlowski-opensource
Copy link
Member

Personally I would be against just marking this one method as public. What I would do instead is to move it to a dedicated service responsible for serializing URLs and its params. Making this move would allow us to solve other issues - namely - difference in serilizing or array request params by different back-ends.

I had a PR for this extract-logic-into-a-service for quite some time so maybe now is the time....

@donaldpipowitch
Copy link
Author

I would totally prefer a separate service which would be used by $http itself, too.

@junhanamaki
Copy link

+1 for this feature.

@ivanff
Copy link

ivanff commented Dec 20, 2014

+1

@pkozlowski-opensource
Copy link
Member

@petebacondarwin I think that you've got super-powers to block users from a repo - @OMarohn is "spamming" all the threads in the AngularJS repo - presumably from an auto-responder...

@petebacondarwin
Copy link
Member

I see what powers I can muster

@pkozlowski-opensource
Copy link
Member

@donaldpipowitch here is my proposal for solving this in 1.4: https://gist.github.com/pkozlowski-opensource/5a57d28ccfeacaba7661 your feedback would be much appreciated.

@parliament718
Copy link

+1 for pkozlowski's solution ... moving buildUrl into a $urlBuilder sevice seems like a good solution to me. Need this functionality

@donaldpipowitch
Copy link
Author

Sounds good to me. +1 for a $urlBuilder service.

@petebacondarwin petebacondarwin modified the milestones: 1.4.x, Backlog Jan 7, 2015
pkozlowski-opensource added a commit to pkozlowski-opensource/angular.js that referenced this issue Jan 24, 2015
pkozlowski-opensource added a commit to pkozlowski-opensource/angular.js that referenced this issue Jan 24, 2015
pkozlowski-opensource added a commit to pkozlowski-opensource/angular.js that referenced this issue Mar 4, 2015
pkozlowski-opensource added a commit to pkozlowski-opensource/angular.js that referenced this issue Mar 4, 2015
pkozlowski-opensource added a commit to pkozlowski-opensource/angular.js that referenced this issue Apr 1, 2015
pkozlowski-opensource added a commit to pkozlowski-opensource/angular.js that referenced this issue Apr 2, 2015
@jmendiara
Copy link
Contributor

@donaldpipowitch @junhanamaki @ivanff Here you have another approach ready to be used in angular > v1.2
http://codepen.io/jmendiara/details/bdGbPN/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
9 participants