feat(http): Please make buildUrl public #7429

Closed
donaldpipowitch opened this Issue May 12, 2014 · 11 comments

Projects

None yet

9 participants

@donaldpipowitch

Feature Request:
It would be great if buildUrl would be public. It is a function which was copied nearly identical into Restangular and I had to do the same for a private module.

@tbosch tbosch added this to the Backlog milestone May 21, 2014
@btford btford removed the gh: issue label Aug 20, 2014
@donaldpipowitch

Any progress on this? We need to do this again for some mocking API service.

@pkozlowski-opensource

Personally I would be against just marking this one method as public. What I would do instead is to move it to a dedicated service responsible for serializing URLs and its params. Making this move would allow us to solve other issues - namely - difference in serilizing or array request params by different back-ends.

I had a PR for this extract-logic-into-a-service for quite some time so maybe now is the time....

@donaldpipowitch

I would totally prefer a separate service which would be used by $http itself, too.

@ryanhart2 ryanhart2 referenced this issue in chieffancypants/angular-loading-bar Nov 28, 2014
Open

Add option to disable cache check #113

@junhanamaki

+1 for this feature.

@ivanff
ivanff commented Dec 20, 2014

+1

@pkozlowski-opensource

@petebacondarwin I think that you've got super-powers to block users from a repo - @OMarohn is "spamming" all the threads in the AngularJS repo - presumably from an auto-responder...

@petebacondarwin
Member

I see what powers I can muster

@pkozlowski-opensource

@donaldpipowitch here is my proposal for solving this in 1.4: https://gist.github.com/pkozlowski-opensource/5a57d28ccfeacaba7661 your feedback would be much appreciated.

@parliament718

+1 for pkozlowski's solution ... moving buildUrl into a $urlBuilder sevice seems like a good solution to me. Need this functionality

@donaldpipowitch

Sounds good to me. +1 for a $urlBuilder service.

@petebacondarwin petebacondarwin modified the milestone: 1.4.x, Backlog Jan 7, 2015
@pkozlowski-opensource pkozlowski-opensource added a commit to pkozlowski-opensource/angular.js that referenced this issue Jan 24, 2015
@pkozlowski-opensource pkozlowski-opensource feat($httpUrlParams): introduce new service abstracting params serial…
…ization

Closes #7429
Closes #9224
6aae996
@pkozlowski-opensource pkozlowski-opensource added a commit to pkozlowski-opensource/angular.js that referenced this issue Jan 24, 2015
@pkozlowski-opensource pkozlowski-opensource feat($httpUrlParams): introduce new service abstracting params serial…
…ization

Closes #7429
Closes #9224
6728785
@pkozlowski-opensource pkozlowski-opensource added a commit to pkozlowski-opensource/angular.js that referenced this issue Mar 4, 2015
@pkozlowski-opensource pkozlowski-opensource feat($httpUrlParams): introduce new service abstracting params serial…
…ization

Closes #7429
Closes #9224
f6f00f0
@pkozlowski-opensource pkozlowski-opensource added a commit to pkozlowski-opensource/angular.js that referenced this issue Mar 4, 2015
@pkozlowski-opensource pkozlowski-opensource feat($httpUrlParams): introduce new service abstracting params serial…
…ization

Closes #7429
Closes #9224
16b3a33
@pkozlowski-opensource pkozlowski-opensource added a commit to pkozlowski-opensource/angular.js that referenced this issue Apr 1, 2015
@pkozlowski-opensource pkozlowski-opensource feat($http): support custom params serializers
Closes #3740
Closes #7429
Closes #9224
12f261e
@pkozlowski-opensource pkozlowski-opensource added a commit to pkozlowski-opensource/angular.js that referenced this issue Apr 2, 2015
@pkozlowski-opensource pkozlowski-opensource feat($http): support custom params serializers
Closes #3740
Closes #7429
Closes #9224
292c757
@jmendiara
Contributor

@donaldpipowitch @junhanamaki @ivanff Here you have another approach ready to be used in angular > v1.2
http://codepen.io/jmendiara/details/bdGbPN/

@netman92 netman92 added a commit to netman92/angular.js that referenced this issue Aug 8, 2015
@pkozlowski-opensource @netman92 pkozlowski-opensource + netman92 feat($http): support custom params serializers
Closes #3740
Closes #7429
Closes #9224
Closes #11461
91cf48f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment