Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(http): Please make buildUrl public #7429
Personally I would be against just marking this one method as public. What I would do instead is to move it to a dedicated service responsible for serializing URLs and its params. Making this move would allow us to solve other issues - namely - difference in serilizing or array request params by different back-ends.
I had a PR for this extract-logic-into-a-service for quite some time so maybe now is the time....
@donaldpipowitch here is my proposal for solving this in 1.4: https://gist.github.com/pkozlowski-opensource/5a57d28ccfeacaba7661 your feedback would be much appreciated.