Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two equal cookies cause of subdomain handling #8324

Closed
qstiegler opened this issue Jul 24, 2014 · 1 comment
Closed

Two equal cookies cause of subdomain handling #8324

qstiegler opened this issue Jul 24, 2014 · 1 comment

Comments

@qstiegler
Copy link

@qstiegler qstiegler commented Jul 24, 2014

On one of our Projects, we´ve got a cookie with the Session ID for the whole domain, so we can also access this id from the subdomains. But if i´m working with $cookies or $cookieStore. It doesn´t look at the domain. So when I change, add or delete another cookie on a subdomain, the function create a duplicate of the Session ID cookie for the subdomain, too.

Please fix this, that if a cookie belongs to another subdomain or like in this case to the main domain, it won´t create a duplicate.

@btford
Copy link
Contributor

@btford btford commented Jul 24, 2014

Please provide a reproduction via jsbin, plnkr.co or jsfiddle

This saves us a lot of time. Thanks!

@btford btford added this to the Backlog milestone Jul 24, 2014
@btford btford removed the gh: issue label Aug 20, 2014
shahata added a commit to shahata/angular.js that referenced this issue Jan 5, 2015
shahata added a commit to shahata/angular.js that referenced this issue Feb 28, 2015
shahata added a commit to shahata/angular.js that referenced this issue Feb 28, 2015
shahata added a commit to shahata/angular.js that referenced this issue Feb 28, 2015
shahata added a commit to shahata/angular.js that referenced this issue Mar 1, 2015
shahata added a commit to shahata/angular.js that referenced this issue Mar 1, 2015
shahata added a commit to shahata/angular.js that referenced this issue Mar 2, 2015
The `put`, `putObject` and `remove` methods now take an options parameter
where you can provide additional options for the cookie value, such as `expires`,
`path`, `domain` and `secure`.

Closes angular#8324
Closes angular#3988
Closes angular#1786
Closes angular#950
shahata added a commit to shahata/angular.js that referenced this issue Mar 2, 2015
The `put`, `putObject` and `remove` methods now take an options parameter
where you can provide additional options for the cookie value, such as `expires`,
`path`, `domain` and `secure`.

Closes angular#8324
Closes angular#3988
Closes angular#1786
Closes angular#950
shahata added a commit to shahata/angular.js that referenced this issue Mar 2, 2015
The `put`, `putObject` and `remove` methods now take an options parameter
where you can provide additional options for the cookie value, such as `expires`,
`path`, `domain` and `secure`.

Closes angular#8324
Closes angular#3988
Closes angular#1786
Closes angular#950
shahata added a commit to shahata/angular.js that referenced this issue Mar 2, 2015
The `put`, `putObject` and `remove` methods now take an options parameter
where you can provide additional options for the cookie value, such as `expires`,
`path`, `domain` and `secure`.

Closes angular#8324
Closes angular#3988
Closes angular#1786
Closes angular#950
shahata added a commit to shahata/angular.js that referenced this issue Mar 2, 2015
The `put`, `putObject` and `remove` methods now take an options parameter
where you can provide additional options for the cookie value, such as `expires`,
`path`, `domain` and `secure`.

Closes angular#8324
Closes angular#3988
Closes angular#1786
Closes angular#950
@shahata shahata closed this in 92c366d Mar 2, 2015
hansmaad pushed a commit to hansmaad/angular.js that referenced this issue Mar 10, 2015
The `put`, `putObject` and `remove` methods now take an options parameter
where you can provide additional options for the cookie value, such as `expires`,
`path`, `domain` and `secure`.

Closes angular#8324
Closes angular#3988
Closes angular#1786
Closes angular#950
netman92 added a commit to netman92/angular.js that referenced this issue Aug 8, 2015
The `put`, `putObject` and `remove` methods now take an options parameter
where you can provide additional options for the cookie value, such as `expires`,
`path`, `domain` and `secure`.

Closes angular#8324
Closes angular#3988
Closes angular#1786
Closes angular#950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.