This repository was archived by the owner on Apr 12, 2024. It is now read-only.
WIP: perf(ngInclude): cache linkFns for each template #10432
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably not the best way to do this but here is a working Proof of Concept. See http://www.bennadel.com/blog/2738-using-ngrepeat-with-nginclude-hurts-performance-in-angularjs.htm
|
CLAs look good, thanks! |
|
Actually this is not right... |
|
OK, that is a bit better. But still this caching could probably be done inside $requestTemplate or $templateCache. |
| @@ -231,6 +233,9 @@ var ngIncludeDirective = ['$templateRequest', '$anchorScroll', '$animate', '$sce | |||
| var newScope = scope.$new(); | |||
| ctrl.template = response; | |||
|
|
|||
| // Compile and cache the template | |||
| ctrl.linkFn = ctrl.linkFns[src] = ctrl.linkFns[src] || $compile(jqLiteBuildFragment(ctrl.template, document).childNodes); | |||
There was a problem hiding this comment.
It is a shame to have to compile this way...
|
@petebacondarwin I was expecting something like lgalfaso@fd70eab |
|
Mine was a PoC to see if it was feasible and what the performance implication was; not an proper implementation. Your commit is closer to a clean solution but effectively the same idea no? |
|
@petebacondarwin yes, it follows the same idea |
|
Pushing to the backlog for now. |
|
I don't think we should do this. It is easy enough to get the caching you need for real application by using a directive with a templateURL instead (IMO). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably not the best way to do this but here is a working Proof of Concept.
See http://www.bennadel.com/blog/2738-using-ngrepeat-with-nginclude-hurts-performance-in-angularjs.htm
Here is demo: http://plnkr.co/edit/Pf9DVKxNEAZQavcGm7Bu?p=preview