feat(filter): support conversion to timezone other than UTC #10858
+20
−6
Conversation
|
If this is something we want, I can do it also for |
| expect(date(new Date(Date.UTC(2003, 8, 10, 3, 2, 4)), 'yyyy-MM-dd HH-mm-ssZ', 'GMT+0500')).toEqual('2003-09-10 08-02-04+0500'); | ||
| }); | ||
|
|
||
| it('should fallback to default timezone in case an unknown timezone was passed', function() { |
petebacondarwin
Jan 26, 2015
Member
Question: Fallback to local or to UTC?
Question: Fallback to local or to UTC?
petebacondarwin
Jan 26, 2015
Member
Or throw?
Or throw?
petebacondarwin
Jan 26, 2015
Member
I guess the current behaviour (before this PR) is to fallback to local time.
I guess the current behaviour (before this PR) is to fallback to local time.
shahata
Jan 26, 2015
Author
Contributor
I currently fallback to local tz, but I can change it if you think UTC is preferred.
I currently fallback to local tz, but I can change it if you think UTC is preferred.
shahata
Jan 26, 2015
Author
Contributor
hmmm, yes, throwing is also a viable option. we could also have the filter output something that indicates a problem. not sure. I don't think we have any other filters that can fail, I'll look into it.
hmmm, yes, throwing is also a viable option. we could also have the filter output something that indicates a problem. not sure. I don't think we have any other filters that can fail, I'll look into it.
petebacondarwin
Jan 27, 2015
Member
Let's go with what you have - it is a reasonable default and it is what happens now.
Let's go with what you have - it is a reasonable default and it is what happens now.
|
LGTM - let's merge and then look at the date input controls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.