Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat(filter): support conversion to timezone other than UTC #10858
Conversation
googlebot
added
the
cla: yes
label
Jan 24, 2015
shahata
referenced this pull request
Jan 24, 2015
Closed
fix(filter): format timezone correctly #9534
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
shahata
Jan 24, 2015
Contributor
If this is something we want, I can do it also for ng-model-options, but let's get this in first
|
If this is something we want, I can do it also for |
petebacondarwin
reviewed
Jan 26, 2015
| expect(date(new Date(Date.UTC(2003, 8, 10, 3, 2, 4)), 'yyyy-MM-dd HH-mm-ssZ', 'GMT+0500')).toEqual('2003-09-10 08-02-04+0500'); | ||
| }); | ||
| it('should fallback to default timezone in case an unknown timezone was passed', function() { |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
petebacondarwin
Jan 26, 2015
Member
I guess the current behaviour (before this PR) is to fallback to local time.
petebacondarwin
Jan 26, 2015
Member
I guess the current behaviour (before this PR) is to fallback to local time.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
shahata
Jan 26, 2015
Contributor
I currently fallback to local tz, but I can change it if you think UTC is preferred.
shahata
Jan 26, 2015
Contributor
I currently fallback to local tz, but I can change it if you think UTC is preferred.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
shahata
Jan 26, 2015
Contributor
hmmm, yes, throwing is also a viable option. we could also have the filter output something that indicates a problem. not sure. I don't think we have any other filters that can fail, I'll look into it.
shahata
Jan 26, 2015
Contributor
hmmm, yes, throwing is also a viable option. we could also have the filter output something that indicates a problem. not sure. I don't think we have any other filters that can fail, I'll look into it.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
petebacondarwin
Jan 27, 2015
Member
Let's go with what you have - it is a reasonable default and it is what happens now.
petebacondarwin
Jan 27, 2015
Member
Let's go with what you have - it is a reasonable default and it is what happens now.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
LGTM - let's merge and then look at the date input controls |
shahata commentedJan 24, 2015
No description provided.