feat(filter): support conversion to timezone other than UTC #10858
Conversation
|
If this is something we want, I can do it also for |
| expect(date(new Date(Date.UTC(2003, 8, 10, 3, 2, 4)), 'yyyy-MM-dd HH-mm-ssZ', 'GMT+0500')).toEqual('2003-09-10 08-02-04+0500'); | ||
| }); | ||
|
|
||
| it('should fallback to default timezone in case an unknown timezone was passed', function() { |
There was a problem hiding this comment.
Question: Fallback to local or to UTC?
There was a problem hiding this comment.
I guess the current behaviour (before this PR) is to fallback to local time.
There was a problem hiding this comment.
I currently fallback to local tz, but I can change it if you think UTC is preferred.
There was a problem hiding this comment.
hmmm, yes, throwing is also a viable option. we could also have the filter output something that indicates a problem. not sure. I don't think we have any other filters that can fail, I'll look into it.
There was a problem hiding this comment.
Let's go with what you have - it is a reasonable default and it is what happens now.
|
LGTM - let's merge and then look at the date input controls |
No description provided.