Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure boolean values for aria-* attributes #11365

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@fredsa
Copy link
Contributor

commented Mar 18, 2015

aria-* (e.g. aria-hidden) values should mirror the truthiness of their ng-*
counterparts (e.g. ng-show, ng-hide) instead of their actual value

Ensure boolean values for aria-* attributes
aria-* (e.g. aria-hidden) values should mirror the truthiness of their ng-*
counterparts (e.g. ng-show, ng-hide) instead of their actual value

@googlebot googlebot added the cla: yes label Mar 18, 2015

@fredsa

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2015

Example of a problem:

<input type="text" model="foo">
<div ng-show="foo">…</div>

If a user types "bar" into the text field, foo will have a string value of "bar" and ng-show will correctly make the div visible. However, with ngAria module in use, aria-hidden attribute will (without this pull request) also have the value "bar", which is invalid. Instead, we want aria-hidden to mirror the truthiness of ng-show, and just have a value of true or false.

@Narretz Narretz added this to the Backlog milestone Mar 19, 2015

@Narretz

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2015

Hi, thanks for the PR. Would you be able to write a test for this?

@Narretz

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2015

Just to make sure, @marcysutton do you think this a valid issue?

@marcysutton

This comment has been minimized.

Copy link
Member

commented Apr 20, 2015

That does sound valid to me–aria-hidden needs a string true or false value to properly hide.

@Narretz Narretz self-assigned this Apr 21, 2015

Narretz added a commit to Narretz/angular.js that referenced this pull request May 28, 2015

Narretz added a commit to Narretz/angular.js that referenced this pull request May 28, 2015

fix(ngAria): ensure boolean values for aria-hidden
aria-hidden should mirror the boolean representation of their ng-*
counterpart (ng-show, ng-hide) instead of their actual value

Closes angular#11365

Narretz added a commit to Narretz/angular.js that referenced this pull request May 28, 2015

fix(ngAria): ensure boolean values for aria-hidden
aria-hidden should mirror the boolean representation of their ng-*
counterpart (ng-show, ng-hide) instead of their actual value

Closes angular#11365

Narretz added a commit to Narretz/angular.js that referenced this pull request Jun 1, 2015

fix(ngAria): ensure boolean values for aria-hidden and aria-disabled
aria-hidden should mirror the boolean representation of their ng-*
counterpart (ng-show, ng-hide) instead of their actual value. Same
applies to aria-disabled and ng-disabled

Closes angular#11365

@Narretz Narretz closed this in 5927335 Jun 1, 2015

netman92 added a commit to netman92/angular.js that referenced this pull request Aug 8, 2015

fix(ngAria): ensure boolean values for aria-hidden and aria-disabled
aria-hidden should mirror the boolean representation of their ng-*
counterpart (ng-show, ng-hide) instead of their actual value. Same
applies to aria-disabled and ng-disabled

Closes angular#11365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.