This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Do a one-off interpolation of @ locals #1488
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eives attributes that are already interpolated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the link fn receives attributes that are already interpolated.
This will make the @ locals consistent with = locals, in that they can be used straight up in the link function.
Currently this confuses many directive developers.
It also requires that they use attrs.$observe to access the interpolated value in the link function even though it could be readily available there.
Obviously, if they want to be able to do work when the interpolated value changes they will still need to create a $observe function but this is currently true of '=' locals, where the initial value is available in the link function but they have to use $watch to deal with changes to the value.
[ Disclaimer: I am running on Windows, and I couldn't get the e2e tests to run but all the unit tests seem to pass.]