Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

perf(ngOptions): prevent initial options repainting #16071

Merged
merged 2 commits into from Jun 29, 2017

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Jun 27, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
See #15812

Please check if the PR fulfills these requirements

Other information:

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

pbr1111 and others added 2 commits June 27, 2017 17:44
Avoid double execution of `updateOptions()` method,
which causes a complete repainting of all `<option>` elements.

Fixes angular#15801
Closes angular#15812
Close angular#16071
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - given that all the tests continue to pass :-)

@Narretz Narretz merged commit 8deff89 into angular:master Jun 29, 2017
Narretz pushed a commit that referenced this pull request Jun 29, 2017
Avoid double execution of `updateOptions()` method,
which causes a complete repainting of all `<option>` elements.

Fixes #15801
Closes #15812
Close #16071
Narretz pushed a commit that referenced this pull request Jun 29, 2017
Avoid double execution of `updateOptions()` method,
which causes a complete repainting of all `<option>` elements.

Fixes #15801
Closes #15812
Close #16071
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants