This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(guide/Conceptual Overview): use exchangeratesapi.io #16808
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs(guide/Conceptual Overview): use another exchange rate API
As fixer.io introduced an API key and thus a limitation of calls (see https://github.com/fixerAPI/fixer#readme), change https://api.fixer.io to https://api.exchangeratesapi.io instead, which is "designed and tested to handle thousands of request per second" and has "built in Fixer.io compatibility so you can keep all the libraries you already like and use daily" (from https://api.exchangeratesapi.io).
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
The finance3.js service module in the Conceptual Overview section of the Angular documentation does not work without an API key. See #16807
What is the new behavior (if this is a feature change)?
Another another currency converter API is used instead (namely the MIT licensed https://api.exchangeratesapi.io), which does not need an API key and which is "designed and tested to handle thousands of request per second"
and has "built in Fixer.io compatibility so you can keep all the libraries you already like and use daily" (from https://api.exchangeratesapi.io). Idea is from #16137
Does this PR introduce a breaking change?
No.
Other information:
The Idea is from fixerAPI/fixer#107
fixes #16807