This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngRepeat): add support for hash for item in items #2216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new method allows to shallow watch collections (Arrays/Maps).
BREAKING CHANGE: Default behavior for hg-repeat is to associate the DOM elements by position rather then by identity. (Previously it was associate by object identity) It is considered an error to have two items produce the same hash key. (This was tolerated before.) To get the old behavior one can simply add the $hash call to the hg-repeat expressions: item in items => $hash(item) for item in items
|
the $watchProp commit needs more tests, few minor changes and we need t discuss the change log that should be part of the change notification |
|
closed and replaced by: #2260 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Default behavior for hg-repeat is to associate the
DOM elements by position rather then by identity.
(Previously it was associate by object identity)
It is considered an error to have two items produce
the same hash key. (This was tolerated before.)
To get the old behavior one can simply add the
$hash call to the hg-repeat expressions:
item in items => $hash(item) for item in items