This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Makes example directive controller minification-safe #3125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've helped a few people who were stuck on minification errors with directive controller functions. Most of them are using the first example in "Writing directives (long version)" as a quick reference. I think it would be better to emphasize that the "controller" property needs to be min safe in there, rather than further down.
petebacondarwin
pushed a commit
that referenced
this pull request
Jul 3, 2013
It is best to emphasize that the "controller" property needs to be min safe Closes #3125
ctrahey
pushed a commit
to ctrahey/angular.js
that referenced
this pull request
Jul 22, 2013
It is best to emphasize that the "controller" property needs to be min safe Closes angular#3125
|
I spent so much time to debug this one. How come this doc still not merged to master? I guess this change has been wiped out from master again. |
|
This was basically reverted by the next patch touching this file, 454bcfa I'm not sure that was intentional, probably a rebase mistake. But either way, that whole section of documentation is gone now, as far as I can tell. |
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've helped a few people who were stuck on minification errors with directive controller functions. Most of them are using the first example in "Writing directives (long version)" as a quick reference. I think it would be better to emphasize that the "controller" property needs to be min safe in there, rather than further down.