Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(CONTRIBUTING.md): fix a broken link to Google Closure I18N lib. #7589

Closed
wants to merge 1 commit into from

Conversation

dalinaum
Copy link

Request Type: docs

How to reproduce:

Component(s):

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

There is a bronken link to Google Clousre I18N lib in CONTRIBUTING.md. This repository has moved to Github. This commit fixes a bronken link.

Other Comments:

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7589)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

There is a bronken link to Google Clousre I18N lib in CONTRIBUTING.md.
This repository has moved to Github. This commit fixes a bronken link.

Closes angular#7589
@dalinaum dalinaum added cla: yes and removed cla: no labels May 28, 2014
@caitp
Copy link
Contributor

caitp commented May 31, 2014

This was fixed already by 3252a50 --- but please submit any PRs you feel are necessary to improve the docs or framework =)

@caitp caitp closed this May 31, 2014
@dalinaum
Copy link
Author

dalinaum commented Jun 1, 2014

I'm very embarrassed. It was not already fixed. 3252a50 is #7638 and my PR is #7589. I doubt very much whether my another PRs shall be merged.

@caitp
Copy link
Contributor

caitp commented Jun 1, 2014

The diff is identical, is what I'm saying. Sorry =[ It happens from time to time

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants