This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Added local to SanitizationWhitelist #8787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTML5 apps on BlackBerry 10 devices use "local" as protocol for local files.
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
I've just signed the CLA. |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
Added test for ´local´'s protocol to be sure `local:///` urls are not sanitized neither `src` nor `href`.
|
Hi @jorgecasar, a few housekeeping items:
|
In some cases, the type of Error thrown by minErr is meaningful, such as in $q where a TypeError is sometimes required. This fix allows providing an error constructor as the second argument to minErr, which will be used to construct the error that gets returned by the factory function.
…r without resolver
jQuery was not included in e2e tests, but we did not notice it as Angular fell back to jqlite…
Angular used to always use the browser timezone for `dateFilter`. An additional parameter was added to allow to use `UTC` timezone instead. Related to #8447.
BREAKING CHANGE: According to the HTML5 spec `input[time]` should create dates based on the year 1970 (used to be based on the year 1900). Related to #8447.
Angular used to always use the browser timezone when parsing `input[date]`, `input[time]`, … The timezone can now be changed to `UTC` via `ngModelOptions`. Closes #8447.
…-local]` The HTML5 spec allows to use seconds for `input[time]` and `input[datetime-local]`, even though they are not displayed by all browsers. Related to #8447.
…emplate" This reverts commit 6d1e7cd. This commit was causing breakages because of its assumption that transcluded content would be handled predictably, i.e. with ngTransclude, whereas many use cases involve manipulating transcluded content in linking functions.
- define `ngModelGet` and `ngModelSet` to already use the getter/setter semantics, so the rest of the code does not need to care about it. - remove `ctrl.$$invalidModelValue` to simplify the internal logic
If the view value changed in the first digest and there are async validators, the view value was never applied to the model after the validators were resolved. Only important for tests.
…nstead of on each link
This changes the example JSON to be the actual bower.json for angular-phonecat, with name set to angular-phonecat.
Previously, if you bound a `Date` object to `<input type="time">`, whenever you changed the time, the day, month, and year fields of the new resulting bound `Date` object would be reset. Now fields not modified by bound time input elements are copied to the new resulting object. Same for input types of `month`, `week`, etc. Closes #6666
Fix typo at i18n generation code. This would remove the property `macFrac` that has no meaning from all the generated locales
The conclusion table incorrectly states that services can not create functions. New table row added to separate "can create functions" and "can create primitives".
|
Sorry, Something goes wrong rebasing my fork |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML5 apps on BlackBerry 10 devices use "local" as protocol for local files.