This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(CHANGELOG.md): add breaking change from 5f3f25a1 #8882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f3f25a included a breaking change which was not documented, which is that the return value of directive constructors is ignored. The reason they are ignored is to ensure that the correct object is bound to when binding properties to the controller. It may be possible to come up with a better solution which informs the developer that what they are doing is wrong, rather than just breaking instead. Closes angular#8876
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5f3f25a included a breaking change which was not documented, which is that
the return value of directive constructors is ignored. The reason they are
ignored is to ensure that the correct object is bound to when binding
properties to the controller. It may be possible to come up with a better
solution which informs the developer that what they are doing is wrong, rather
than just breaking instead.
Closes #8876