Skip to content

Commit 696f7bc

Browse files
josephperrottalxhub
authored andcommitted
fix(bazel): update build tooling for latest changes in rules_nodejs (#40710)
Update the build tooling to handle the changes in the latest version of rules_nodejs. PR Close #40710
1 parent cbdb5e2 commit 696f7bc

File tree

4 files changed

+4
-13
lines changed

4 files changed

+4
-13
lines changed

integration/bazel/.bazelrc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,3 @@ build --define=enable_legacy_rollup_rule=1
2222

2323
# Don't create symlinks
2424
build --symlink_prefix=/
25-
26-
# Turn on managed directories feature in Bazel
27-
# This allows us to avoid installing a second copy of node_modules
28-
# common --experimental_allow_incremental_repository_updates

packages/bazel/src/BUILD.bazel

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,12 @@ exports_files(glob(["*.bzl"]))
1111

1212
load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
1313

14-
filegroup(
15-
name = "empty_node_modules",
16-
srcs = [],
17-
)
18-
1914
nodejs_binary(
2015
name = "modify_tsconfig",
21-
data = ["modify_tsconfig.js"],
16+
data = [
17+
"modify_tsconfig.js",
18+
],
2219
entry_point = ":modify_tsconfig.js",
23-
node_modules = ":empty_node_modules",
2420
visibility = ["//visibility:public"],
2521
)
2622
# END-DEV-ONLY

packages/bazel/src/ng_package/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ load("@npm//@bazel/typescript:index.bzl", "ts_library")
4949
ts_library(
5050
name = "lib",
5151
srcs = glob(["*.ts"]),
52-
node_modules = "@npm//typescript:typescript__typings",
5352
tsconfig = ":tsconfig.json",
5453
deps = [
5554
"@npm//@types/node",

packages/bazel/src/ngc-wrapped/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ ts_library(
99
"index.ts",
1010
],
1111
module_name = "@angular/bazel",
12-
node_modules = "@npm//typescript:typescript__typings",
1312
tsconfig = ":tsconfig.json",
1413
visibility = [
1514
"//packages/bazel:__pkg__",
@@ -21,6 +20,7 @@ ts_library(
2120
"@npm//@types/node",
2221
"@npm//tsickle",
2322
"@npm//typescript",
23+
"@npm//typescript:typescript__typings",
2424
],
2525
)
2626

0 commit comments

Comments
 (0)