ngc codegen quotes properties, which breaks closure compiler

[alexeagle]

Say I configure my routes with

export const routes: Routes = [
  {path: 'search', redirectTo: '/'}, {path: '', component: SearchVideos},
  {path: 'upload', component: UploadVideos}
];

ngc produces an ngfactory.ts containing:

  get _ROUTES_40():any[] {
      if ((this.__ROUTES_40 == (null as any))) { (this.__ROUTES_40 = [[
        {
          'path': 'search',
          'redirectTo': '/'
        }
        ,
        {
          'path': '',
          'component': import38.SearchVideos
        }
        ,
        {
          'path': 'upload',
          'component': import39.UploadVideos
        }

      ]
    ]); }
    return this.__ROUTES_40;
  }

note that redirectTo got quoted as 'redirectTo'

When closure compiler renames the redirectTo property to some short name, it won't rename the one in the ngfactory.ts because it's quoted.

[tbosch]

We should do whatever the user wrote is put into the generated code.
I.e. if the user used {path:...} we should use path, if the user used {'path': ...} we should use 'path'.

[alexeagle]

I did update the metadata collector to preserve quotes: 8e87ce0

But @tbosch thought more about places in the expression parser that would need to change to match the semantics. Instead we'll just stop quoting properties in codegen map literals.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}