Repackaging 2.0 #11120
Repackaging 2.0 #11120
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
mhevery
force-pushed
the
repackaging-2.0
branch
5 times, most recently
from
74e5a12 to
61a07b6
Compare
|
I attempted to shrinkwrap by cloning https://github.com/mhevery/tsickle and https://github.com/mhevery/tslint, but it did not seem to work. Will wait on monday. |
mhevery
force-pushed
the
repackaging-2.0
branch
10 times, most recently
from
b1d2656 to
a96e3ac
Compare
| @@ -67,9 +67,6 @@ export declare class DefaultUrlSerializer implements UrlSerializer { | |||
| } | |||
|
|
|||
| /** @stable */ | |||
| export declare type ErrorHandler = (error: any) => any; | |||
There was a problem hiding this comment.
yes, ErrorHandler is exported by core not by router.
| ] | ||
| }, | ||
| BaseConfig)); | ||
| } else if (platform == 'router') { |
There was a problem hiding this comment.
added new route comment
mhevery
force-pushed
the
repackaging-2.0
branch
4 times, most recently
from
0a8890e to
1c5f158
Compare
IgorMinar
added
pr_state: LGTM
action: merge
mhevery
force-pushed
the
repackaging-2.0
branch
from
1c5f158 to
d09754e
Compare
| find ${DESTDIR} -type f -name '*.d.ts' -print0 | xargs -0 sed -i '' -e 's/\(^ *(static |private )*\)*readonly */\1/g' | ||
| find ${DESTDIR} -type f -name '*.d.ts' -print0 | xargs -0 sed -i '' -E 's/^( +)abstract ([[:alnum:]]+\:)/\1\2/g' | ||
| find ${DESTDIR} -type f -name '*.d.ts' -print0 | xargs -0 sed -i '' -e 's/\(^ *(static |private )*\)*readonly */\1/g' | ||
| find ${DESTDIR} -type f -name '*.d.ts' -print0 | xargs -0 sed -i '' -e 's/\/\/\/ <reference types="node" \/>//g' |
|
Martin, make sure that you don't have any deep imports into the "src" in your case it looks like you are using webpack 1, which should by default On Wed, Aug 31, 2016 at 5:32 AM Martin-Wegner notifications@github.com
|
|
@IgorMinar thanks, you are right, the ng2-bootstrap folks use deep imports :( |
|
@Martin-Wegner this would be a good time to explore a library that is not using private APIs: https://github.com/ng-bootstrap/ng-bootstrap :-) |
|
@pkozlowski-opensource thanks for the hint, but your issue ng-bootstrap/ng-bootstrap#646 scares me from using it... |
|
ng-bootstrap/ng-bootstrap#646 is for our demo page, nothing to do with the library itself. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@devtag to be compatible with tsc@nextmoduleandtypingsentriesglobalsconfiguration for RxJS