fix(reflection_capability): make injection work on inherited directives #12892

lacolaco · 2016-11-15T15:34:19Z

superseded #8991

… 2 Components/Directives Makes it DI work when inheriting Components/Directives/Services from built-in Angular 2 Components/Directives/Services while using standard typescript compiler

…d/angular into laco-inherit-injection # Conflicts: # build.sh # modules/@angular/core/src/reflection/reflection_capabilities.ts

googlebot · 2016-11-15T15:34:21Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

lacolaco · 2016-11-15T15:40:10Z

I want to squash commits in this PR, but if I do it original author will be disappeared. Can I do it or any good solutions?

vicb · 2016-11-15T16:50:49Z

modules/playground/src/inherit_from_angular/index.ts

+      _viewContainerRef: ViewContainerRef, _templateRef: TemplateRef<Object>,
+      myService: MyService) {
+    super(_viewContainerRef, _templateRef);
+    console.log(myService);


vicb · 2016-11-15T16:55:35Z

Keep the original author first commit and squash your commits.

I think we should have more test, including low level ones:

Make sure a Component, Directive or Pipe decoration on a derived class override the decorator on the base class,
Make sure a Pipe, ... decorator on a derived class does not modify the original metadata,
Make sur Input and Output on from the base class does not affect the derived class,
There should be an integration that runs in both JiT and AoT mode - see angular/modules/@angular/compiler-cli/integrationtest

Thanks

hannahhoward · 2016-11-16T03:07:19Z

Hi everyone! Many apologies for my absence -- yes life has moved on and I donut have time to complete this. Can answer questions for whomever is taking on this work.

vicb · 2016-11-16T19:02:50Z

@hannahhoward mo pb, thanks for the initial work on this.

Closes angular#11606 Closes angular#12892

@input

Inheritance Semantics: Class Decorators: 1) list all decorators of all parent classes and of the class itself (in this order) 2) only use the last decorator of each kind (e.g. @component / ...) Constructor parameters: - if a class inherits from a parent class and does not declare a constructor, it inherits the parent class constructor, and with it the parameter metadata of that parent class. Property / Method decorators: 1) per property / method, list all decorators of all parent classes and of the class itself (in this order) 2) per property, only use the last decorator of each kind (e.g. @input / ...) Lifeclyce hooks: Merge the lifecycle hooks of all parent classes and of the class itself E.g. the following is a valid use of inheritance and it will also inherit all metadata: ``` @directive( class ParentDirective { constructor(someDep: SomeDep) {} } class ChildDirective extends ParentDirective {} ``` Closes angular#11606 Closes angular#12892

@directive

Decorators: 1) list the decorators of the class and its parents in the ancestor first order 2) only use the last decorator of each kind (e.g. @component / ...) Constructor parameters: If a class inherits from a parent class and does not declare a constructor, it inherits the parent class constructor, and with it the parameter metadata of that parent class. Lifecycle hooks: Merge the lifecycle hooks of all parent classes and of the class itself ## Example E.g. the following is a valid use of inheritance and it will also inherit all metadata: ``` @directive({selector: 'someDir'}) class ParentDirective { constructor(someDep: SomeDep) {} } class ChildDirective extends ParentDirective {} ``` Closes angular#11606 Closes angular#12892

@directive

## Inheritance Semantics: Decorators: 1) list the decorators of the class and its parents in the ancestor first order 2) only use the last decorator of each kind (e.g. @component / ...) Constructor parameters: If a class inherits from a parent class and does not declare a constructor, it inherits the parent class constructor, and with it the parameter metadata of that parent class. Lifecycle hooks: Follow the normal class inheritance model, i.e. lifecycle hooks of parent classes will be called even if the method is not overwritten in the child class. ## Example E.g. the following is a valid use of inheritance and it will also inherit all metadata: ``` @directive({selector: 'someDir'}) class ParentDirective { constructor(someDep: SomeDep) {} ngOnInit() {} } class ChildDirective extends ParentDirective {} ``` Closes angular#11606 Closes angular#12892

@directive

## Inheritance Semantics: Decorators: 1) list the decorators of the class and its parents in the ancestor first order 2) only use the last decorator of each kind (e.g. @component / ...) Constructor parameters: If a class inherits from a parent class and does not declare a constructor, it inherits the parent class constructor, and with it the parameter metadata of that parent class. Lifecycle hooks: Follow the normal class inheritance model, i.e. lifecycle hooks of parent classes will be called even if the method is not overwritten in the child class. ## Example E.g. the following is a valid use of inheritance and it will also inherit all metadata: ``` @directive({selector: 'someDir'}) class ParentDirective { constructor(someDep: SomeDep) {} ngOnInit() {} } class ChildDirective extends ParentDirective {} ``` Closes angular#11606 Closes angular#12892

lacolaco · 2016-11-23T05:29:44Z

@vicb Bosch seems started adding inheritance support into the compiler layer. so I think this PR is no longer needed. should I close here and wait for that?

#11606 (comment)

@directive

## Inheritance Semantics: Decorators: 1) list the decorators of the class and its parents in the ancestor first order 2) only use the last decorator of each kind (e.g. @component / ...) Constructor parameters: If a class inherits from a parent class and does not declare a constructor, it inherits the parent class constructor, and with it the parameter metadata of that parent class. Lifecycle hooks: Follow the normal class inheritance model, i.e. lifecycle hooks of parent classes will be called even if the method is not overwritten in the child class. ## Example E.g. the following is a valid use of inheritance and it will also inherit all metadata: ``` @directive({selector: 'someDir'}) class ParentDirective { constructor(someDep: SomeDep) {} ngOnInit() {} } class ChildDirective extends ParentDirective {} ``` Closes angular#11606 Closes angular#12892

@directive

## Inheritance Semantics: Decorators: 1) list the decorators of the class and its parents in the ancestor first order 2) only use the last decorator of each kind (e.g. @component / ...) Constructor parameters: If a class inherits from a parent class and does not declare a constructor, it inherits the parent class constructor, and with it the parameter metadata of that parent class. Lifecycle hooks: Follow the normal class inheritance model, i.e. lifecycle hooks of parent classes will be called even if the method is not overwritten in the child class. ## Example E.g. the following is a valid use of inheritance and it will also inherit all metadata: ``` @directive({selector: 'someDir'}) class ParentDirective { constructor(someDep: SomeDep) {} ngOnInit() {} } class ChildDirective extends ParentDirective {} ``` Closes angular#11606 Closes angular#12892

@directive

## Inheritance Semantics: Decorators: 1) list the decorators of the class and its parents in the ancestor first order 2) only use the last decorator of each kind (e.g. @component / ...) Constructor parameters: If a class inherits from a parent class and does not declare a constructor, it inherits the parent class constructor, and with it the parameter metadata of that parent class. Lifecycle hooks: Follow the normal class inheritance model, i.e. lifecycle hooks of parent classes will be called even if the method is not overwritten in the child class. ## Example E.g. the following is a valid use of inheritance and it will also inherit all metadata: ``` @directive({selector: 'someDir'}) class ParentDirective { constructor(someDep: SomeDep) {} ngOnInit() {} } class ChildDirective extends ParentDirective {} ``` Closes angular#11606 Closes angular#12892

mrgoos · 2016-11-26T06:48:05Z

Hey guys, any news on that?
Thanks.

@directive

## Inheritance Semantics: Decorators: 1) list the decorators of the class and its parents in the ancestor first order 2) only use the last decorator of each kind (e.g. @component / ...) Constructor parameters: If a class inherits from a parent class and does not declare a constructor, it inherits the parent class constructor, and with it the parameter metadata of that parent class. Lifecycle hooks: Follow the normal class inheritance model, i.e. lifecycle hooks of parent classes will be called even if the method is not overwritten in the child class. ## Example E.g. the following is a valid use of inheritance and it will also inherit all metadata: ``` @directive({selector: 'someDir'}) class ParentDirective { constructor(someDep: SomeDep) {} ngOnInit() {} } class ChildDirective extends ParentDirective {} ``` Closes angular#11606 Closes angular#12892

@directive

## Inheritance Semantics: Decorators: 1) list the decorators of the class and its parents in the ancestor first order 2) only use the last decorator of each kind (e.g. @component / ...) Constructor parameters: If a class inherits from a parent class and does not declare a constructor, it inherits the parent class constructor, and with it the parameter metadata of that parent class. Lifecycle hooks: Follow the normal class inheritance model, i.e. lifecycle hooks of parent classes will be called even if the method is not overwritten in the child class. ## Example E.g. the following is a valid use of inheritance and it will also inherit all metadata: ``` @directive({selector: 'someDir'}) class ParentDirective { constructor(someDep: SomeDep) {} ngOnInit() {} } class ChildDirective extends ParentDirective {} ``` Closes angular#11606 Closes angular#12892

@directive

## Inheritance Semantics: Decorators: 1) list the decorators of the class and its parents in the ancestor first order 2) only use the last decorator of each kind (e.g. @component / ...) Constructor parameters: If a class inherits from a parent class and does not declare a constructor, it inherits the parent class constructor, and with it the parameter metadata of that parent class. Lifecycle hooks: Follow the normal class inheritance model, i.e. lifecycle hooks of parent classes will be called even if the method is not overwritten in the child class. ## Example E.g. the following is a valid use of inheritance and it will also inherit all metadata: ``` @directive({selector: 'someDir'}) class ParentDirective { constructor(someDep: SomeDep) {} ngOnInit() {} } class ChildDirective extends ParentDirective {} ``` Closes angular#11606 Closes angular#12892

mlc-mlapis · 2016-12-17T09:22:56Z

@tbosch If I understand correctly "template/templateUrl" or "styles/styleUrls" on a base component are now ignored from a derived component point of view now.

I read all discussion about the problem (like https://docs.google.com/document/d/16D3U3wdDBMEncUUEXBxiCaI11SnhjBijggZGq8JMjP0) again and I still do not understand why there are difficulties on decission how to inherit "template/templateUrl" or "styles/styleUrls" between a base and a derived component.

What is wrong on the following rules?

If a derived component does not declare template or styles then both are taken from its base component, if exists,
if a derived component declares them (in any variant) then definitions are taken from this derived component on the same rules as it would be a normal (base) component.

That is all. A programmer who writes the code has the same chance to make a mistake and it does not matter whether it is on a base or on a derived component.

angular-automatic-lock-bot · 2019-09-10T11:22:54Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

hannahhoward and others added 3 commits June 2, 2016 23:21

fix(DI): make DI work on Components/Directives inherited from Angular…

cb63472

… 2 Components/Directives Makes it DI work when inheriting Components/Directives/Services from built-in Angular 2 Components/Directives/Services while using standard typescript compiler

Merge branch 'DI_inherited_directives_8700' of github.com:hannahhowar…

2cc8878

…d/angular into laco-inherit-injection # Conflicts: # build.sh # modules/@angular/core/src/reflection/reflection_capabilities.ts

refactor

96087fe

googlebot added the cla: no label Nov 15, 2016

refactor

38dcc97

vicb reviewed Nov 15, 2016

View reviewed changes

vicb added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime labels Nov 15, 2016

tbosch mentioned this pull request Nov 18, 2016

fix(DI): make DI work on Components/Directives inherited from Angular #8991

Closed

7 tasks

mhevery assigned tbosch Nov 19, 2016

tbosch added a commit to tbosch/angular that referenced this pull request Nov 22, 2016

feat(core): property support inheritance

222f9a7

Closes angular#11606 Closes angular#12892

tbosch added a commit to tbosch/angular that referenced this pull request Nov 22, 2016

feat(core): property support inheritance

f3751e8

Closes angular#11606 Closes angular#12892

vsavkin closed this in f5c8e09 Nov 28, 2016

lacolaco deleted the laco-inherit-injection branch November 29, 2016 06:25

amcdnl mentioned this pull request Dec 5, 2016

Setup proper inheritance swimlane/ngx-charts#114

Closed

angular-automatic-lock-bot bot unassigned tbosch Sep 10, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(reflection_capability): make injection work on inherited directives #12892

fix(reflection_capability): make injection work on inherited directives #12892

lacolaco commented Nov 15, 2016

googlebot commented Nov 15, 2016

lacolaco commented Nov 15, 2016

vicb Nov 15, 2016

vicb commented Nov 15, 2016

hannahhoward commented Nov 16, 2016

vicb commented Nov 16, 2016

lacolaco commented Nov 23, 2016

mrgoos commented Nov 26, 2016

mlc-mlapis commented Dec 17, 2016

angular-automatic-lock-bot bot commented Sep 10, 2019

fix(reflection_capability): make injection work on inherited directives #12892

fix(reflection_capability): make injection work on inherited directives #12892

Conversation

lacolaco commented Nov 15, 2016

googlebot commented Nov 15, 2016

lacolaco commented Nov 15, 2016

vicb Nov 15, 2016

Choose a reason for hiding this comment

vicb commented Nov 15, 2016

hannahhoward commented Nov 16, 2016

vicb commented Nov 16, 2016

lacolaco commented Nov 23, 2016

mrgoos commented Nov 26, 2016

mlc-mlapis commented Dec 17, 2016

angular-automatic-lock-bot bot commented Sep 10, 2019