Skip to content

Conversation

cexbrayat
Copy link
Member

@cexbrayat cexbrayat commented Jan 25, 2017

params has been introduced in 4.0.0-beta.0

Before:

http.get(url, new RequestOptions({params: searchParams}))

After:

http.get(url, {params: searchParams})

Fixes #14100

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

See #14100

http.get(url, new RequestOptions({params: searchParams}))

What is the new behavior?

http.get(url, {params: searchParams})

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

`params` has been introduced in 4.0.0-beta.0

Before:

    http.get(url, new RequestOptions({params: searchParams}))

After:

    http.get(url, {params: searchParams})

Fixes angular#14100
@mhevery mhevery closed this in 5f2b317 Jan 31, 2017
mhevery pushed a commit that referenced this pull request Feb 3, 2017
`params` has been introduced in 4.0.0-beta.0

Before:

    http.get(url, new RequestOptions({params: searchParams}))

After:

    http.get(url, {params: searchParams})

Fixes #14100

PR Close #14101
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
`params` has been introduced in 4.0.0-beta.0

Before:

    http.get(url, new RequestOptions({params: searchParams}))

After:

    http.get(url, {params: searchParams})

Fixes angular#14100

PR Close angular#14101
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
`params` has been introduced in 4.0.0-beta.0

Before:

    http.get(url, new RequestOptions({params: searchParams}))

After:

    http.get(url, {params: searchParams})

Fixes angular#14100

PR Close angular#14101
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[http] RequestOptions is necessary for params (introduced in 4.0.0-beta.0)
3 participants