fix(core): ErrorHandler should not rethrow an error by default (#15077) #15208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckjaz
suggested changes
Mar 16, 2017
packages/core/src/error_handler.ts
Outdated
| @@ -43,11 +43,9 @@ export class ErrorHandler { | |||
| _console: Console = console; | |||
|
|
|||
| /** | |||
| * @internal | |||
| * @deprecated since v4.0 parameter no longer has an effect, as ErrorHandler will never rethrow. | |||
There was a problem hiding this comment.
You must leave @internal or you will break implementors of this class.
There was a problem hiding this comment.
Also the field is not deprecated, the parameter is.
There was a problem hiding this comment.
I think you should overload the constructor and deprecate the one with parameter
chuckjaz
approved these changes
Mar 16, 2017
…ar#15077) ErrorHandler can not throw errors because it will unsubscribe itself from the error stream. Zones captures errors and feed it into NgZone, which than has a Rx Observable to feed it into ErrorHandler. If the ErroHandler throws, then Rx will teardown the observable which in essence causes the ErrorHandler to be removed from the error handling. This implies that the ErrorHandler can never throw errors. Closes angular#14949 Closes angular#15182 Closes angular#14316
|
@chuckjaz @mhevery btw IDE doesn't cross out constructor when parameter is deprecated: but with constructor overload it does |
SamVerschueren
pushed a commit
to SamVerschueren/angular
that referenced
this pull request
Mar 18, 2017
…ar#15077) (angular#15208) ErrorHandler can not throw errors because it will unsubscribe itself from the error stream. Zones captures errors and feed it into NgZone, which than has a Rx Observable to feed it into ErrorHandler. If the ErroHandler throws, then Rx will teardown the observable which in essence causes the ErrorHandler to be removed from the error handling. This implies that the ErrorHandler can never throw errors. Closes angular#14949 Closes angular#15182 Closes angular#14316
|
Unfortunately #14316 is not fixed by this PR |
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…ar#15077) (angular#15208) ErrorHandler can not throw errors because it will unsubscribe itself from the error stream. Zones captures errors and feed it into NgZone, which than has a Rx Observable to feed it into ErrorHandler. If the ErroHandler throws, then Rx will teardown the observable which in essence causes the ErrorHandler to be removed from the error handling. This implies that the ErrorHandler can never throw errors. Closes angular#14949 Closes angular#15182 Closes angular#14316
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…ar#15077) (angular#15208) ErrorHandler can not throw errors because it will unsubscribe itself from the error stream. Zones captures errors and feed it into NgZone, which than has a Rx Observable to feed it into ErrorHandler. If the ErroHandler throws, then Rx will teardown the observable which in essence causes the ErrorHandler to be removed from the error handling. This implies that the ErrorHandler can never throw errors. Closes angular#14949 Closes angular#15182 Closes angular#14316
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrorHandler can not throw errors because it will unsubscribe itself from
the error stream.
Zones captures errors and feed it into NgZone, which than has a Rx Observable
to feed it into ErrorHandler. If the ErroHandler throws, then Rx will teardown
the observable which in essence causes the ErrorHandler to be removed from the
error handling. This implies that the ErrorHandler can never throw errors.
Closes #14949
Closes #15182
Closes #14316