ExpressionChangedAfterItHasBeenCheckedError when changing a component 'non model' value in afterViewInit

[adrienboulle]

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request

Current behavior
changing a component 'non model' value in afterViewInit throws ExpressionChangedAfterItHasBeenCheckedError if the value has an impact on a method used in the view.

in the plunker:
-> getTextDecoration() returns none before ngAfterViewInit is called (isViewInit === false)
-> getTextDecoration() returns underline after ngAfterViewInit is called (isViewInit === true)

Expected behavior
it should not throw the error since getTextDecoration is just a method and not part of the model.

Minimal reproduction of the problem with instructions
http://plnkr.co/edit/k8AsppUH8V2RvPeLJ0JT?p=preview

• Angular version: 4.0.0 => KO
• Angular version: 4.0.0-beta.8 => OK

[DzmitryShylovich]

cc @tbosch

[jesussobrino]

@adrienboulle It's still happening in Angular 4.0.1. (I've just get updated)

[chrishandorf]

I'm on 4.0.1 and also getting this error

[ThomasKerbrat]

I had a similar issue when I wanted to dynamically create a component with resolveComponentFactory and inserting the created component back into the template.
Looking at the lifecyle hooks documentation, I changed ngAfterViewInit to ngAfterContentInit and it worked.

Hope it helps ;)

[adrienboulle]

@jesussobrino indeed i've checked the plunker which use @next and the error is still thrown

[tbosch]

This is works as intended, as you are using getTextDecoration() in your template. Therefore Angular will call it whenever it dirty checks your template. I.e. Angular only looks at the resulting values of expressions...

In dev mode (i.e. you didn't call enableProdMode()), angular does 2 dirty checks:

• 1x to apply new values and
• 1x afterwards to check that nothing has changed (to enforce the unidirectional data flow).

[adrienboulle]

@tbosch so it was a bug that it worked on angular@2.0.0->2.4.6 ?

[tbosch]

@adrienboulle yes, this was a bug before. In general, whenever you change a bound value during change detection, you should expect this kind of error...

[adrienboulle]

ok thanks :)