Skip to content

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Sep 6, 2017

Remove an assertion that is no longer true. This was supposed to be removed in #18998, but was somehow dropped from 66a5dab (probably due to a bad rebase).

(Travis has been failing due to this since https://travis-ci.org/angular/angular/jobs/272321759.)

@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release area: i18n Issues related to localization and internationalization labels Sep 6, 2017
@mary-poppins
Copy link

You can preview 189cf57 at https://pr19070-189cf57.ngbuilds.io/.

Remove an assertion that is no longer true. This was supposed to be removed in angular#18998,
but was somehow dropped from 66a5dab (probably due to a bad rebase).

(Travis has been failing due to this since
https://travis-ci.org/angular/angular/jobs/272321759.)
@mary-poppins
Copy link

You can preview 5341b4b at https://pr19070-5341b4b.ngbuilds.io/.

@mhevery mhevery merged commit 29762f1 into angular:master Sep 6, 2017
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 6, 2017
@gkalpak gkalpak deleted the test-aio-fix-tests branch September 6, 2017 18:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: i18n Issues related to localization and internationalization cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants