refactor(compiler): remove old ngtools api and add listLazyRoutes to … #19836

tbosch · 2017-10-20T18:36:10Z

…new api

Usages of NgTools_InternalApi_NG_2 from @angular/compiler-cli will now
throw an error.

Adds listLazyRoutes to @angular/compiler-cli/ngtools2.ts for getting
the lazy routes of a ng.Program.

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

chuckjaz · 2017-10-20T18:39:48Z

packages/compiler-cli/src/main.ts

@@ -28,15 +28,15 @@ export function main(
  let {project, rootNames, options, errors: configErrors, watch, emitFlags} =
      config || readNgcCommandLineAndConfiguration(args);
  if (configErrors.length) {
-    return reportErrorsAndExit(configErrors, consoleError);
+    return reportErrorsAndExit(configErrors, undefined, consoleError);


Put a /* options */ in front of undefined to indicate what parameter you are skipping.

mary-poppins · 2017-10-20T18:48:55Z

You can preview a2d6859 at https://pr19836-a2d6859.ngbuilds.io/.

tbosch · 2017-10-20T19:54:02Z

Fails now on the expected error Error: Please update @angular/cli. Angular 5+ requires at least Angular CLI 1.5+.

mary-poppins · 2017-10-20T21:16:32Z

You can preview 2fcfa6c at https://pr19836-2fcfa6c.ngbuilds.io/.

mary-poppins · 2017-10-20T22:00:27Z

You can preview 8ee2997 at https://pr19836-8ee2997.ngbuilds.io/.

mary-poppins · 2017-10-20T22:21:47Z

You can preview 45fbada at https://pr19836-45fbada.ngbuilds.io/.

Replacing the old API. We keep the old API because we need it for JIT (with either --aot=false or unittests). Depends on angular/angular#19836

mary-poppins · 2017-10-20T23:10:36Z

You can preview a54e059 at https://pr19836-a54e059.ngbuilds.io/.

mary-poppins · 2017-10-20T23:53:49Z

You can preview f878222 at https://pr19836-f878222.ngbuilds.io/.

mary-poppins · 2017-10-23T16:09:55Z

You can preview b1123f6 at https://pr19836-b1123f6.ngbuilds.io/.

mary-poppins · 2017-10-23T17:01:18Z

You can preview 8efa16e at https://pr19836-8efa16e.ngbuilds.io/.

mary-poppins · 2017-10-23T17:32:27Z

You can preview 4d0161c at https://pr19836-4d0161c.ngbuilds.io/.

mary-poppins · 2017-10-23T18:01:54Z

You can preview b164603 at https://pr19836-b164603.ngbuilds.io/.

Replacing the old API. We keep the old API because we need it for JIT (with either --aot=false or unittests). Depends on angular/angular#19836

tbosch · 2017-10-23T20:15:51Z

Regarding the approval for root: I talked to @IgorMinar about them, so this PR is good to go.

Replacing the old API. We keep the old API because we need it for JIT (with either --aot=false or unittests). Depends on angular/angular#19836

tbosch · 2017-10-23T20:54:29Z

This is also green in G3.

…new api Usages of `NgTools_InternalApi_NG_2` from `@angular/compiler-cli` will now throw an error. Adds `listLazyRoutes` to `@angular/compiler-cli/ngtools2.ts` for getting the lazy routes of a `ng.Program`.

…f the `rootDir`. Fixes angular#19718

…f the `rootDir`. (#19836) Fixes #19718 PR Close #19836

mary-poppins · 2017-10-23T22:49:05Z

You can preview 52a8f2b at https://pr19836-52a8f2b.ngbuilds.io/.

Replacing the old API. We keep the old API because we need it for JIT (with either --aot=false or unittests). Depends on angular/angular#19836

gkalpak · 2017-10-24T07:10:43Z

aio/package.json

@@ -7,7 +7,7 @@
  "license": "MIT",
  "scripts": {
    "aio-use-local": "node tools/ng-packages-installer overwrite . --debug --ignore-packages @angular/service-worker",
-    "aio-use-npm": "node tools/ng-packages-installer restore .",
+    "aio-use-npm": "node tools/ng-packages-installer restore . && yarn upgrade @angular/cli@1.3.0",


What is this change for? Is this supposed to use the same version as currently specified in the lockfile?
Can we remove the changes in aio/package.json once we upgrade to @angular/cli@1.5.0-rc.2 (or higher)?

IgorMinar · 2017-10-24T09:41:48Z

once we upgrade to cli rc.3 we can remove this bit.

…

On Tue, Oct 24, 2017 at 12:10 AM George Kalpakas ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In aio/package.json <#19836 (comment)>: > @@ -7,7 +7,7 @@ "license": "MIT", "scripts": { "aio-use-local": "node tools/ng-packages-installer overwrite . --debug --ignore-packages @angular/service-worker", - "aio-use-npm": "node tools/ng-packages-installer restore .", + "aio-use-npm": "node tools/ng-packages-installer restore . && yarn upgrade @***@***.***", What is this change for? Is this supposed to use the same version as currently specified in the lockfile? Can we remove the changes in aio/package.json once we upgrade to @***@***.*** (or higher)? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19836 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANM6MTW9-H2O2dnBMaXLHkTh0KwhtRNks5svY14gaJpZM4QBD85> .

Replacing the old API. We keep the old API because we need it for JIT (with either --aot=false or unittests). Depends on angular/angular#19836

angular-automatic-lock-bot · 2019-09-12T19:51:29Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

tbosch requested review from chuckjaz and hansl October 20, 2017 18:36

googlebot added the cla: yes label Oct 20, 2017

chuckjaz approved these changes Oct 20, 2017

View reviewed changes

tbosch force-pushed the remove_old_api branch from a2d6859 to 2fcfa6c Compare October 20, 2017 21:06

tbosch force-pushed the remove_old_api branch 2 times, most recently from 8ee2997 to aa5802d Compare October 20, 2017 21:50

tbosch force-pushed the remove_old_api branch from aa5802d to 45fbada Compare October 20, 2017 22:11

hansl mentioned this pull request Oct 20, 2017

fix(@angular/cli): use the new compiler API for listLazyRoutes angular/angular-cli#8136

Merged

tbosch force-pushed the remove_old_api branch from 45fbada to a54e059 Compare October 20, 2017 23:00

tbosch force-pushed the remove_old_api branch from a54e059 to f878222 Compare October 20, 2017 23:40

tbosch force-pushed the remove_old_api branch from f878222 to b1123f6 Compare October 23, 2017 15:59

tbosch force-pushed the remove_old_api branch from b1123f6 to 8efa16e Compare October 23, 2017 16:48

tbosch force-pushed the remove_old_api branch from 8efa16e to 4d0161c Compare October 23, 2017 17:19

tbosch force-pushed the remove_old_api branch from 4d0161c to b164603 Compare October 23, 2017 17:52

tbosch added area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Oct 23, 2017

hansl approved these changes Oct 23, 2017

View reviewed changes

tbosch added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Oct 23, 2017

mhevery approved these changes Oct 23, 2017

View reviewed changes

tbosch added the action: merge The PR is ready for merge by the caretaker label Oct 23, 2017

tbosch added 2 commits October 23, 2017 14:59

refactor(compiler): remove old ngtools api and add listLazyRoutes to …

a1a60ae

…new api Usages of `NgTools_InternalApi_NG_2` from `@angular/compiler-cli` will now throw an error. Adds `listLazyRoutes` to `@angular/compiler-cli/ngtools2.ts` for getting the lazy routes of a `ng.Program`.

fix(compiler): correctly calculate the outDir if it repeats a parts o…

52a8f2b

…f the `rootDir`. Fixes angular#19718

tbosch force-pushed the remove_old_api branch from b164603 to 52a8f2b Compare October 23, 2017 22:34

tbosch mentioned this pull request Oct 23, 2017

fix(compiler): correctly calculate the outDir if it repeats a parts o… #19772

Closed

3 tasks

matsko pushed a commit that referenced this pull request Oct 23, 2017

fix(compiler): correctly calculate the outDir if it repeats a parts o…

fc0b1d5

…f the `rootDir`. (#19836) Fixes #19718 PR Close #19836

matsko closed this in 8d45fef Oct 23, 2017

gkalpak reviewed Oct 24, 2017

View reviewed changes

gkalpak mentioned this pull request Oct 24, 2017

build(aio): update to @angular/core@5.0.0-rc.5 #19702

Closed

sarunint mentioned this pull request Oct 25, 2017

Compiler CLI requests Angular CLI 1.5+ for builds done via webpack #19913

Closed

tbosch deleted the remove_old_api branch November 1, 2017 16:16

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019

refactor(compiler): remove old ngtools api and add listLazyRoutes to … #19836

refactor(compiler): remove old ngtools api and add listLazyRoutes to … #19836

Uh oh!

Conversation

tbosch commented Oct 20, 2017

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

chuckjaz Oct 20, 2017

Choose a reason for hiding this comment

Uh oh!

tbosch Oct 20, 2017

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Oct 20, 2017

Uh oh!

tbosch commented Oct 20, 2017

Uh oh!

mary-poppins commented Oct 20, 2017

Uh oh!

mary-poppins commented Oct 20, 2017

Uh oh!

mary-poppins commented Oct 20, 2017

Uh oh!

mary-poppins commented Oct 20, 2017

Uh oh!

mary-poppins commented Oct 20, 2017

Uh oh!

mary-poppins commented Oct 23, 2017

Uh oh!

mary-poppins commented Oct 23, 2017

Uh oh!

mary-poppins commented Oct 23, 2017

Uh oh!

mary-poppins commented Oct 23, 2017

Uh oh!

tbosch commented Oct 23, 2017

Uh oh!

tbosch commented Oct 23, 2017

Uh oh!

mary-poppins commented Oct 23, 2017

Uh oh!

gkalpak Oct 24, 2017

Choose a reason for hiding this comment

Uh oh!

IgorMinar commented Oct 24, 2017 via email

Uh oh!

angular-automatic-lock-bot bot commented Sep 12, 2019

Uh oh!

Uh oh!