fix(@angular/cli): use the new compiler API for listLazyRoutes #8136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
force-pushed
the
new-lazy-route-api
branch
4 times, most recently
from
0d5ca2a to
073282e
Compare
filipesilva
previously approved these changes
Oct 23, 2017
| @@ -80,14 +80,20 @@ export enum PLATFORM { | |||
| Server | |||
| } | |||
|
|
|||
| export interface LazyRoute { | |||
There was a problem hiding this comment.
Can you add this to the private interface instead?
https://github.com/angular/angular-cli/blob/master/packages/%40ngtools/webpack/src/ngtools_api.ts
This file should reflect what we believe the private interface is.
There was a problem hiding this comment.
We can do this after 5.0 is out.
hansl
force-pushed
the
new-lazy-route-api
branch
from
073282e to
abe14d5
Compare
filipesilva
previously approved these changes
Oct 23, 2017
Before it would try to load the package from the CLI project, as a regular require() call, now it adds a check to see if it can be resolved from the process.cwd(), before doing the previous behaviour.
Replacing the old API. We keep the old API because we need it for JIT (with either --aot=false or unittests). Depends on angular/angular#19836
hansl
force-pushed
the
new-lazy-route-api
branch
from
abe14d5 to
edc0e8b
Compare
Brocco
approved these changes
Oct 24, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the old API. We keep the old API because we need it for JIT
(with either --aot=false or unittests).
Depends on angular/angular#19836