Skip to content

Conversation

chuckjaz
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?

Issue Number: #21811

What is the new behavior?

Language service works correctly on Windows.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@chuckjaz chuckjaz added the target: patch This PR is targeted for the next patch release label Jan 26, 2018
The 2.6 version of TypeScript's `resolveModuleName`  started to
require paths passed to be separated by '/' instead of being
able to handle '\'.

`ngc` and `ng` already do this transformation.

Fixes: angular#21811
@mary-poppins
Copy link

You can preview 8a2b687 at https://pr21812-8a2b687.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 2338a88 at https://pr21812-2338a88.ngbuilds.io/.

@mary-poppins
Copy link

You can preview a3e1059 at https://pr21812-a3e1059.ngbuilds.io/.

let ngService = createLanguageService(ngHost);
const reflectorHost = new ReflectorHost(() => undefined as any, mockHost, {basePath: '\\app'});

spyOn(path, 'join').and.callFake((...args: string[]) => { return path.win32.join(...args); });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove { return and } ie (...) => path.win32.join(...)

@chuckjaz chuckjaz added action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service labels Jan 26, 2018
@jasonaden jasonaden closed this in 2b68e8d Jan 26, 2018
jasonaden pushed a commit that referenced this pull request Jan 26, 2018
…21812)

The 2.6 version of TypeScript's `resolveModuleName`  started to
require paths passed to be separated by '/' instead of being
able to handle '\'.

`ngc` and `ng` already do this transformation.

Fixes: #21811

PR Close #21812
jasonaden pushed a commit that referenced this pull request Jan 26, 2018
jasonaden pushed a commit that referenced this pull request Jan 26, 2018
…21812)

The 2.6 version of TypeScript's `resolveModuleName`  started to
require paths passed to be separated by '/' instead of being
able to handle '\'.

`ngc` and `ng` already do this transformation.

Fixes: #21811

PR Close #21812
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants