fix(language-service): ensure correct paths are passed to typescript #21812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckjaz
force-pushed
the
ls-windows-paths
branch
from
8a2b687
to
2338a88
Compare
The 2.6 version of TypeScript's `resolveModuleName` started to require paths passed to be separated by '/' instead of being able to handle '\'. `ngc` and `ng` already do this transformation. Fixes: angular#21811
chuckjaz
force-pushed
the
ls-windows-paths
branch
from
2338a88
to
a3e1059
Compare
|
You can preview 8a2b687 at https://pr21812-8a2b687.ngbuilds.io/. |
|
You can preview 2338a88 at https://pr21812-2338a88.ngbuilds.io/. |
|
You can preview a3e1059 at https://pr21812-a3e1059.ngbuilds.io/. |
vicb
reviewed
Jan 26, 2018
| let ngService = createLanguageService(ngHost); | ||
| const reflectorHost = new ReflectorHost(() => undefined as any, mockHost, {basePath: '\\app'}); | ||
|
|
||
| spyOn(path, 'join').and.callFake((...args: string[]) => { return path.win32.join(...args); }); |
There was a problem hiding this comment.
nit: remove { return and } ie (...) => path.win32.join(...)
vicb
approved these changes
Jan 26, 2018
chuckjaz
added
action: merge
jasonaden
pushed a commit
that referenced
this pull request
Jan 26, 2018
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
…ngular#21812) The 2.6 version of TypeScript's `resolveModuleName` started to require paths passed to be separated by '/' instead of being able to handle '\'. `ngc` and `ng` already do this transformation. Fixes: angular#21811 PR Close angular#21812
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
…ngular#21812) The 2.6 version of TypeScript's `resolveModuleName` started to require paths passed to be separated by '/' instead of being able to handle '\'. `ngc` and `ng` already do this transformation. Fixes: angular#21811 PR Close angular#21812
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #21811
What is the new behavior?
Language service works correctly on Windows.
Does this PR introduce a breaking change?