Documentation for RxJS Unsubscribing

[spottedmahn]

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[X] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

I can't seem to find any information on unsubscribing from RxJS objects in Angular.

I've found a few online articles that discuss it

• When to Unsubscribe in Angular
• Angular: Don't forget to unsubscribe()

Expected behavior

It would be nice to get some official guidance on this topic.

Maybe it is there and I just can't find it? I've been googling "angular rxjs unsubscribe"

[ericmartinezr]

See if this PR talks about it #21423. If it doesn't it would be a good idea to ask to be added imo

[spottedmahn]

Thanks! I reviewed that PR, I don't see anything. I asked... we'll see!

[wKoza]

This topic is evocated at different places in the documentation. We can find example in the Router documentation ;

When subscribing to an observable in a component, you almost always arrange to unsubscribe when the component is destroyed.
There are a few exceptional observables where this is not necessary. The ActivatedRoute observables are among the exceptions.
The ActivatedRoute and its observables are insulated from the Router itself. The Router destroys a routed component when it is no longer needed and the injected ActivatedRoute dies with it.

Feel free to unsubscribe anyway. It is harmless and never a bad practice.

This explain they are, directly related to a technical element (router, Http) rather than a generaly.

[jasonaden]

This is a good question, and yes, it needs to be documented. I assigned to myself to be addressed in a follow-up to #21423

[jenniferfell]

I added @jbogarthyde as another assignee, so it's on her radar to add this to her backlog for RxJS doc as well.

[seangwright]

I collected information about this in a SO answer that has some traction (it appears devs are using the approach I document).

I would be happy to update my answer there again to point to the documentation once it's released.

There is also this issue which was closed asking about a specific scenario of what I assume the PR will cover