feat(bazel): change ng_package rule to APF v6 #22782
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview ab9382d at https://pr22782-ab9382d.ngbuilds.io/. |
|
You can preview 2ae2bf6 at https://pr22782-2ae2bf6.ngbuilds.io/. |
|
You can preview c424ff5 at https://pr22782-c424ff5.ngbuilds.io/. |
Angular Package Format v6 stops bundling files in the esm5 and esm2015 directories, now that Webpack 4 can tree-shake per-file. Adds some missing files like package.json to make packages closer to what we publish today. Refactor ng_package to be a type of npm_package and re-use the packaging action from that rule.
|
You can preview 7bc9ee2 at https://pr22782-7bc9ee2.ngbuilds.io/. |
IgorMinar
reviewed
Mar 15, 2018
| # esm5/ and esm2015/ folders. | ||
| for f in esm5_sources.to_list(): | ||
| if f.path.endswith(".js"): | ||
| esm5.append(struct(js = f, map = None)) |
There was a problem hiding this comment.
are the source maps inlined in js? that's why no .map files?
IgorMinar
approved these changes
Mar 15, 2018
|
the ci failure looks like a flake. I restarted the builds. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular Package Format v6 stops bundling files in the esm5 and esm2015
directories, now that Webpack 4 can tree-shake per-file.
Adds some missing files like package.json to make packages closer to
what we publish today.
Refactor ng_package to be a type of npm_package and re-use the packaging
action from that rule.