Skip to content

fix(bazel): move bazel managed runtime deps for downstream usage #25690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(bazel): move bazel managed runtime deps for downstream usage #25690

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

At the moment downstream (NG CLI) we are having this error

ERROR: /home/circleci/ng/etc/api/BUILD:3:2: no such package '@ts-api-guardian_runtime_deps//': The repository could not be resolved and referenced by '//etc/api:angular_devkit_architect_testing_api.accept'

What is the new behavior?

Move mananged runtime deps into ng_setup_workspace

Does this PR introduce a breaking change?

[ ] Yes
[X] No

//cc @alexeagle

@alexeagle alexeagle added the target: major This PR is targeted for the next major release label Aug 27, 2018
@alexeagle alexeagle self-requested a review August 27, 2018 21:02
@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Aug 27, 2018
@matsko matsko closed this in 6ed7993 Aug 27, 2018
@alan-agius4 alan-agius4 deleted the feature_workspace branch August 27, 2018 22:26
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants