fix(core): CSS sanitizer now allows parens in file names #30322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves an issue where images that were created with a name like `'foo (1).png'` would not pass CSS url sanitization.
benlesh
added
type: bug/fix
freq1: low
area: core
mhevery
approved these changes
May 8, 2019
alfaproject
reviewed
May 8, 2019
alxhub
pushed a commit
that referenced
this pull request
May 8, 2019
Resolves an issue where images that were created with a name like `'foo (1).png'` would not pass CSS url sanitization. PR Close #30322
alxhub
pushed a commit
that referenced
this pull request
May 8, 2019
Resolves an issue where images that were created with a name like `'foo (1).png'` would not pass CSS url sanitization. PR Close #30322
alxhub
added a commit
to alxhub/angular
that referenced
this pull request
May 14, 2019
…ular#30322)" This reverts commit 728db88. We're reverting this commit for now, until it can be subjected to a more thorough security review.
alxhub
added a commit
that referenced
this pull request
May 14, 2019
alxhub
added a commit
that referenced
this pull request
May 14, 2019
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
Resolves an issue where images that were created with a name like `'foo (1).png'` would not pass CSS url sanitization. PR Close angular#30322
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…ular#30322)" (angular#30463) This reverts commit 728db88. We're reverting this commit for now, until it can be subjected to a more thorough security review. PR Close angular#30463
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where images that were created with a name like
'foo (1).png'would not pass CSS url sanitization.