fix(common): update $locationShim to notify onChange listeners before… #32037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… emitting AngularJS events The $locationShim has onChange listeners to allow for synchronization logic between AngularJS and Angular. When the AngularJS routing events are emitted first, this can cause Angular code to be out of sync. Notifying the listeners earlier solves the problem.
petebacondarwin
approved these changes
Aug 7, 2019
alxhub
added
the
area: common
kara
added
action: presubmit
|
Global TAP presubmit passed: https://test.corp.google.com/ui#id=OCL:262973801:BASE:262952437:1565659296935:d49307b2 |
kara
added
action: merge
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
… emitting AngularJS events (angular#32037) The $locationShim has onChange listeners to allow for synchronization logic between AngularJS and Angular. When the AngularJS routing events are emitted first, this can cause Angular code to be out of sync. Notifying the listeners earlier solves the problem. PR Close angular#32037
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… emitting AngularJS events
The $locationShim has onChange listeners to allow for synchronization logic between
AngularJS and Angular. When the AngularJS routing events are emitted first, this can
cause Angular code to be out of sync. Notifying the listeners earlier solves the
problem.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Listeners to the $locationShim onChange are notified after the $locationChangeSuccess or $locationChangeStart events.
Issue Number: N/A
What is the new behavior?
Listeners to the $locationShim onChange are notified immediately before the $locationChangeSuccess or $locationChangeStart events.
Does this PR introduce a breaking change?
If someone is already using this method and depending on the existing ordering of events then technically this could be breaking. But the contract for the onChange method doesn't make any guarentees about the ordering of these events, it just says that the listeners are notified.
Other information
See b/138246666 for more details on the Google internal bug causing this change.