fix(ivy): ensure that window.ng utilities are published when NgModules are used
#32725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorMinar
approved these changes
Sep 17, 2019
…les are used Prior to this patch if any backwards-compatible Angular code was using Ivy then the built-in `window.ng` debug utilies would not be exposed.
matsko
force-pushed
the
window_ng_fixes
branch
from
4d92635 to
42868e9
Compare
matsko
added
comp: ivy
target: major
AndrewKushnir
added
action: presubmit
|
FYI, VE and Ivy presubmits look normal. Thank you. |
alan-agius4
reviewed
Sep 19, 2019
| // included into Angular when PRE mode is active. | ||
| export function publishDefaultGlobalUtils__PRE_R3__() {} | ||
| export function publishDefaultGlobalUtils__POST_R3__() { | ||
| ngDevMode && _publishDefaultGlobalUtils(); |
There was a problem hiding this comment.
We should check if ngDevMode is undefined to avoid possible ReferenceErrors when not using Angular with the CLI directly.
See: #32079
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch if any backwards-compatible Angular code was using
Ivy then the built-in
window.ngdebug utilies would not be exposed.