-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(ivy): i18n problem with select ICU expressions #34018
Comments
Hi @osnoser1, thanks for reporting the issue. The problem appeared because an ICU defined in the
There is a check that verifies "other" case presence and throws the error. That check was implemented to better align with ICU format spec, which states that the "other" case is required:
However since "other" cases were not required in View Engine, we decided to change this condition in Ivy as well to better align with existing behavior and I've created a PR to remove the mentioned check. Meanwhile you can update ICUs to add "other" cases (with empty content) to avoid the problem until the mentioned PR lands. Here is an example of the original ICU with the "other" case:
Thank you. |
Thanks @AndrewKushnir for the detailed explanation and for workaround while merging the PR. Really grateful. |
@osnoser1, just want to let you know that the fix from the mentioned PR was included into v9.0.0-rc.4, which was released a few hours ago and is now available on NPM. I'll close this ticket, but feel free to reopen it if the problem still exists. Thank you. |
Thank you very much @AndrewKushnir 😄 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
🐞 bug report
Affected Package
The issue is caused by package @angular/....Is this a regression?
Yes, works with VE.
Description
When using a select icu expression throws an exception at runtime.
🔬 Minimal Reproduction
Use select ICU expressions in angular apps.
Minimal repo: https://github.com/osnoser1/angular9-i18n-ivy-ssr
ng serve -c es
🔥 Exception or Error
🌍 Your Environment
Angular Version:
Anything else relevant?
The text was updated successfully, but these errors were encountered: