feat(language-service): [ivy] Parse Angular compiler options #36922
Conversation
kyliau
added
area: language-service
| if (!(project instanceof ts.server.ConfiguredProject)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
What happens if someone starts the LS in a project with no tsconfig, then adds a tsconfig later on? Not saying we should worry about it, but we won't detect the config change right?
There was a problem hiding this comment.
Our application is using a prepare script to generate the tsconfig and angular configuration files because the files were getting huge, so we are now "building" the configuration files.
It would be nice to have this working with Ivy.
There was a problem hiding this comment.
@SchnWalter when is the config file built? Today TypeScript only supports static analysis of tsconfig.json files. The language service relies only on tsconfig, not on other config files like angular.json.
There was a problem hiding this comment.
We generate our tsconfig.json file on npm postinstall for CI pipelines and on localhost we also use some some IDE launch commands, and this allows us to test various combinations of libraries/projects. And it would be nice to not have to manually reload the TypeScript services or restart the IDEs whenever we regenerate the tsconfig files.
In the mono-repository we have quite a few libraries and several projects that consume them and most packages also support multiple "feature flags" which are also using various tsconfig path aliases.
There was a problem hiding this comment.
I think this kind of request is better targeted at TypeScript. Angular only consumes TypeScript APIs. Sounds like you are looking for a conditional build system that tsconfig does not support. There is a long-open proposal for conditional compilation directives, which could be somewhat related.
There was a problem hiding this comment.
What happens if someone starts the LS in a project with no tsconfig, then adds a tsconfig later on? Not saying we should worry about it, but we won't detect the config change right?
Good question! tsserver automatically takes care of situation like this. Without a tsconfig, an InferredProject is created to host the scripts. Upon creation of a tsconfig in the workspace, the scripts will be transferred to a ConfiguredProject, the old project will be disposed along with the language service, and a new language service will be created.
I added a TODO here to make sure we clean up the FileWatcher when this happens.
Parse Angular compiler options in Angular language service. In View Engine, only TypeScript compiler options are read, Angular compiler options are not. With Ivy, there could be different modes of compilation, most notably how strict the templates should be checked. This commit makes the behavior of language service consistent with the Ivy compiler.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…#36922) Parse Angular compiler options in Angular language service. In View Engine, only TypeScript compiler options are read, Angular compiler options are not. With Ivy, there could be different modes of compilation, most notably how strict the templates should be checked. This commit makes the behavior of language service consistent with the Ivy compiler. PR Close angular#36922
Parse Angular compiler options in Angular language service.
In View Engine, only TypeScript compiler options are read, Angular
compiler options are not. With Ivy, there could be different modes of
compilation, most notably how strict the templates should be checked.
This commit makes the behavior of language service consistent with the
Ivy compiler.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information