feat(language-service): [ivy] wrap ngtsc to handle typecheck files #36930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
area: language-service
kyliau
force-pushed
the
ivy-ls-compiler
branch
2 times, most recently
from
74f1954 to
ccedb48
Compare
ayazhafiz
suggested changes
May 5, 2020
kyliau
force-pushed
the
ivy-ls-compiler
branch
2 times, most recently
from
95306b6 to
1acc580
Compare
ayazhafiz
reviewed
May 5, 2020
ayazhafiz
reviewed
May 5, 2020
ayazhafiz
approved these changes
May 5, 2020
kyliau
changed the title
kyliau
force-pushed
the
ivy-ls-compiler
branch
2 times, most recently
from
65ec034 to
fd1c68d
Compare
kyliau
changed the title
kyliau
force-pushed
the
ivy-ls-compiler
branch
3 times, most recently
from
d857305 to
0c6bc01
Compare
ayazhafiz
reviewed
May 6, 2020
ayazhafiz
approved these changes
May 7, 2020
This commit adds a Compiler interface that wraps the actual ngtsc compiler. The language-service specific compiler manages multiple typecheck files using the Project interface, creating and adding ScriptInfos as necessary. This commit also adds `overrideInlineTemplate()` method to the mock service so that we could test the Compiler diagnostics feature.
3 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…ngular#36930) This commit adds a Compiler interface that wraps the actual ngtsc compiler. The language-service specific compiler manages multiple typecheck files using the Project interface, creating and adding ScriptInfos as necessary. This commit also adds `overrideInlineTemplate()` method to the mock service so that we could test the Compiler diagnostics feature. PR Close angular#36930
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a Compiler interface that wraps the actual ngtsc
compiler. The language-service specific compiler manages multiple
typecheck files using the Project interface, creating and adding
ScriptInfos as necessary.
This commit also adds
overrideInlineTemplate()method to the mockservice so that we could test the Compiler diagnostics feature.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information