fix(changelog): include refactor commits

[jeffbcross]

The Changelog seems to omit any refactor commits, even those with breaking changes. For example: 5514dc1

^^^
That commit was not included

CC @robwormald

[pkozlowski-opensource]

It is kind of reasonable since refactor shouldn't have impact on the functionality as seen by an user (in our case those are framework users). Perhaps commit should reflect why we even doing this change, from a user point of view?

[jeffbcross]

It is kind of reasonable since refactor shouldn't have impact on the functionality as seen by an user (in our case those are framework users).

In angular reality though, refactors almost always have some kind of user-impacting change, breaking or not. When I, and I think most other contributors, think of "fix", I think of it as a solution to an obvious bug. When I think of refactor, it's usually to either improve performance or developer experience. Like the lifecycle hook refactor wasn't in response to a "bug", but a potential problem with the current design. And the recent Observable refactor was mostly a performance improvement (byte reduction). Same with the upcoming kebab-case refactor.

Perhaps commit should reflect why we even doing this change

Agreed

[vicb]

Concrete example: #5709 should really be a refactor but as it is also a breaking change, I've labelled it as fix.

[jeffbcross]

I think probably a better solution to this problem would be to include any commit that is a breaking change.

[pkozlowski-opensource]

I think probably a better solution to this problem would be to include any commit that is a breaking change.

👍

[jeffbcross]

@pkozlowski-opensource @vicb a PR is ready #5762

I considered changing the angular preset upstream, in the conventional-changelog repo. Not sure if this problem is general enough that others would want it though.

@ajoslin do you think it'd be worth adding logic to the angular preset in conventional-changelog that would include any commit that contains a BREAKING CHANGE note, regardless of its type?

[ajoslin]

That sounds reasonable. @stevemao is currently maintaining conventional-changelog. Steve, what do you think?

[stevemao]

Sounds good to me.
It's called angular preset so it should follow whatever angular is doing