[BETA-6] Gesture (swipeleft) event makes Zone throw Maximum call size exceeded

[jimjim2a]

Hi,

Since Beta-2, it seems that gesture management using Hammer cause Zone to throw "Maximum call size exceeded".

Here's a reproductible plunk :

http://plnkr.co/edit/OLNs58Bp0HKjMROdW6yy?p=preview

Thx !

[Barryrowe]

Just ran into this using @HostListener('tap') for a custom directive as well.

[jimjim2a]

Updated plunk to use Beta 6, issue still there.

[asukaleido]

+1

[asukaleido]

https://github.com/angular/angular/blob/master/modules/angular2/src/platform/dom/events/hammer_gestures.ts#L18-L30

  addEventListener(element: HTMLElement, eventName: string, handler: Function): Function {
    var zone = this.manager.getZone();
    eventName = eventName.toLowerCase();

    return zone.runOutsideAngular(function() {
      // Creating the manager bind events, must be done outside of angular
      var mc = new Hammer(element);
      mc.get('pinch').set({enable: true});
      mc.get('rotate').set({enable: true});
      var handler = function(eventObj) { zone.run(function() { handler(eventObj); }); };
      mc.on(eventName, handler);
      return () => { mc.off(eventName, handler); };
    });
  }

handleris defined by arguments.

  var handler = function(eventObj) { zone.run(function() { handler(eventObj); }); };

Here is an infinite loop.

  addEventListener(element: HTMLElement, eventName: string, handler: Function): Function {
    var zone = this.manager.getZone();
    eventName = eventName.toLowerCase();

    return zone.runOutsideAngular(function() {
      // Creating the manager bind events, must be done outside of angular
      var mc = new Hammer(element);
      mc.get('pinch').set({enable: true});
      mc.get('rotate').set({enable: true});
      var callback = function(eventObj) { zone.run(function() { handler(eventObj); }); };
      mc.on(eventName, callback);
      return () => { mc.off(eventName, callback); };
    });
  }

It can be fixed in this.

+1 I ran to the same issue.

[trakhimenok]

Is is fixed by 41e38e4?

[davidgodzsak]

@astec yes it is.

[CaptainCodeman]

no it isn't

[kara]

@CaptainCodeman Are you checking on master or beta.9? The fix is only on master at the moment (and will go into our next beta release).

[CaptainCodeman]

Oh, I thought it was in the beta-9 release. There was no changelog so it wasn't clear.
http://plnkr.co/edit/Ic99R2YdhHKVk3EDjkaK?p=preview