Dependency Injection not working for Components/Directives inherited from Angular2 Components/Directives.

[sergeykhomyuk]

Dependency Injection not working for Components/Directives inherited from Angular2 Components/Directives if using TypeScript Compiler instead of Angular Template Compiler.

Steps to reproduce and a minimal demo of the problem

1. Define DatePicker directive inherited from DefaultValueAccessor.
2. Add any additional parameter to DatePicker constructor (e.g. logger: Logger).
3. Compile source code with TypeScript Compiler.
4. Run application.

@Injectable()
class Logger {}

@Directive({
  selector: '[datePicker]'
})
class DatePicker extends DefaultValueAccessor {
   constructor(renderer: Renderer, element: ElementRef, logger: Logger) {
     super(renderer, element);
     if (!logger) {
      console.error('Logger is undefined');
     } else {
       console.info('Logger is defined');
     }
   }
}

Minimal demo: http://plnkr.co/edit/UIybCDlayhXRO7x0Y7Lk?p=preview

Current behavior
DatePicker resolved using ctorParameters from DefaultValueAccessor (renderer, element) instead of metadata from DatePicker constructor (renderer, element, logger).
(see ReflectionCapabilities.parameters(typeOrFunc: Type): any[][] implementation for details)

Expected/desired behavior
DatePicker resolved using parameters from its constructor metadata (renderer, element, logger).

Other information
Current implementation of ReflectionCapabilities.parameters(typeOrFunc: Type): any[][] work properly only if code was compiled using Angular Template Compiler, otherwise it will never check metadata, because ctorParameters decorator data inherited from parent hides it.

[cristi-badila]

The same thing seems to happen to other classes/services which inherit from angular classes.
In a case I observed, a custom Http service which inherits from angular Http always gets injected with only the dependencies of the base class even though it has other constructor parameters which can be resolved by the injector. I created a small plunker to reproduce the issue here.

[sometimesitcompiles]

Same with XHRBackend in my case- I can see in the injector's providers that XHRBackend is tied to my "useclass" type. However, when instantiating my type the "dependencies" is set an array with only the base type's 2 parameter types. My additional 2 parameters have the @Inject decorator to providers that I can see as available in the injector.

Typescript generated metadata is included below:

CustomXHRBackend = __decorate([
core_1.Injectable(),
__param(2, core_1.Inject(BASE_URL)),
__param(3, core_1.Inject(TOKEN)),
__metadata('design:paramtypes', [(typeof (_a = typeof http_1.BrowserXhr !== 'undefined' && http_1.BrowserXhr) === 'function' && _a) || Object, (typeof (_b = typeof http_1.ResponseOptions !== 'undefined' && http_1.ResponseOptions) === 'function' && _b) || Object, String, String])
], CustomXHRBackend);

[pe8ter]

Anecdotally, our RouterOutlet subclass has no issues with DI in rc.1. Not sure what could be making the difference.

[hannahhoward]

PR Submitted for a fix, #8991